gcs: use the + for concatenattion in Error()

dfinkel · dfinkel · commit 74d2e6fe9aa4 · 2022-03-25T10:13:38.000-04:00
Don't use fmt.Sprintf when you're just concatenating two strings.
diff --git a/gcs/decider.go b/gcs/decider.go
@@ -150,7 +150,7 @@ type failedAcquisitionErr struct {
 }
 
 func (f *failedAcquisitionErr) Error() string {
-	return fmt.Sprintf("failed to acquire lock: %s", f.err)
+	return "failed to acquire lock: " + f.err.Error()
 }
 
 func (f *failedAcquisitionErr) Unwrap() error {

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ type failedAcquisitionErr struct {`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`func (f *failedAcquisitionErr) Error() string {`
`153`		`- return fmt.Sprintf("failed to acquire lock: %s", f.err)`
	`153`	`+ return "failed to acquire lock: " + f.err.Error()`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`func (f *failedAcquisitionErr) Unwrap() error {`