updated the doc comment and renamed the package

Author: jeffdupont

otmetric/find.go otmetricreader/find.gootmetric/find.go renamed to otmetricreader/find.go

@@ -9,8 +9,16 @@ import (
 	"go.opentelemetry.io/otel/sdk/metric/metricdata"
 )
 
-// FindMetricVal returns the current value of a [metricName] from the [ManualReader].
-func FindMetricVal[V int64 | float64](ctx context.Context, r *otsdkmetric.ManualReader, metricName string, kvs attribute.Set) (V, error) {
+// FindVal is a testing utility to find the value of a specific metric
+// collected by the sdk metric.ManualReader.
+//
+// It searches for a metric matching the provided metricName and attribute.Set.
+// The type parameter V specifies the expected value type, which must be
+// either int64 or float64.
+//
+// An error is returned if a metric matching the name and attributes is not found,
+// or if the found metric's value type does not match V.
+func FindVal[V int64 | float64](ctx context.Context, r *otsdkmetric.ManualReader, metricName string, kvs attribute.Set) (V, error) {
 	var zv V
 	res := metricdata.ResourceMetrics{}
 	if err := r.Collect(ctx, &res); err != nil {

otmetric/find_test.go otmetricreader/find_test.gootmetric/find_test.go renamed to otmetricreader/find_test.go

@@ -25,7 +25,7 @@ func TestFindMetricVal(t *testing.T) {
 	}
 	counter.Add(ctx, 2, metric.WithAttributeSet(attrSet))
 
-	counterVal, counterValErr := FindMetricVal[int64](ctx, r, "a_counter_int", attrSet)
+	counterVal, counterValErr := FindVal[int64](ctx, r, "a_counter_int", attrSet)
 	if counterValErr != nil {
 		t.Errorf("failed to fetch counter metric value: %s", counterValErr)
 	}
@@ -40,7 +40,7 @@ func TestFindMetricVal(t *testing.T) {
 	}
 	gauge.Record(ctx, 3, metric.WithAttributeSet(attrSet))
 
-	gaugeVal, gaugeValErr := FindMetricVal[int64](ctx, r, "a_gauge_int", attrSet)
+	gaugeVal, gaugeValErr := FindVal[int64](ctx, r, "a_gauge_int", attrSet)
 	if gaugeValErr != nil {
 		t.Errorf("failed to fetch gauge metric value: %s", gaugeValErr)
 	}