Merge pull request #11629 from danog/improve_getIssueTrace

Improve performance of getIssueTrace

Author: danog

psalm-baseline.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="6.x-dev@2b0ff73c8bed091af231a0a80ac109126c92083a">
+<files psalm-version="6.x-dev@bbd217fc98c0daa0a13aea2a7f119d03ba3fc9a0">
   <file src="examples/TemplateChecker.php">
     <PossiblyUndefinedIntArrayOffset>
       <code><![CDATA[$comment_block->tags['variablesfrom'][0]]]></code>
@@ -1612,8 +1612,11 @@
       <code><![CDATA[$path->escaped_taints]]></code>
       <code><![CDATA[$path->unescaped_taints]]></code>
       <code><![CDATA[$source->specialization_key]]></code>
-      <code><![CDATA[end($source->path_types)]]></code>
+      <code><![CDATA[end($path_types)]]></code>
     </RiskyTruthyFalsyComparison>
+    <UnnecessaryVarAnnotation>
+      <code><![CDATA[DataFlowNode]]></code>
+    </UnnecessaryVarAnnotation>
   </file>
   <file src="src/Psalm/Internal/Composer.php">
     <RiskyTruthyFalsyComparison>

src/Psalm/Internal/Codebase/TaintFlowGraph.php

@@ -38,6 +38,7 @@
 use function array_intersect;
 use function array_merge;
 use function array_unique;
+use function array_unshift;
 use function count;
 use function end;
 use function implode;
@@ -183,23 +184,23 @@ public function getSuccessorPath(DataFlowNode $sink): string
      */
     public function getIssueTrace(DataFlowNode $source): array
     {
-        $previous_source = $source->previous;
-
-        $node = [
-            'location' => $source->code_location,
-            'label' => $source->label,
-            'entry_path_type' => end($source->path_types) ?: '',
-        ];
-
-        if ($previous_source) {
+        $out = [];
+        do {
+            /** @var DataFlowNode $source */
+            $previous_source = $source->previous;
             if ($previous_source === $source) {
-                return [];
+                break;
             }
-
-            return [...$this->getIssueTrace($previous_source), $node];
-        }
-
-        return [$node];
+            $path_types = $source->path_types;
+            array_unshift($out, [
+                'location' => $source->code_location,
+                'label' => $source->label,
+                'entry_path_type' => end($path_types) ?: '',
+            ]);
+            $source = $previous_source;
+        } while ($previous_source);
+
+        return $out;
     }
 
     public function connectSinksAndSources(): void