Skip to content

Commit 3b90a60

Browse files
committed
fix: issue 916: `When zooming in Firefox 24: TypeError...'
The following revision to `firefox' (notice the `$REV_FF' in the URI): REV_FF=f8057a4c1e18536842dc1876e5daae9a1e58c6b7 http://hg.mozilla.org/mozilla-central/rev/$REV_FF altered the signature of the following [quite possibly private] method: _applyZoomToPref as seen here (notice the `$REF_FF' in the URI): http://hg.mozilla.org/mozilla-central/rev/$REV_FF#l1.383 - _applyZoomToPref: function FullZoom__applyZoomToPref() { + _applyZoomToPref: function FullZoom__applyZoomToPref(browser) { I'm guessing that the response in the `vimperator' code is the following (notice the `$REV_VIMP' in the URI): REV_VIMP=5862dce879ce5089c85674b49024ab1a8087de25 http://code.google.com/p/vimperator-labs/source/detail?r=$REV_VIMP Fri Sep 20 02:13:03 2013 +0900 fix: "TypeError: FullZoom._applySettingToPref is not a function" Fixes issue 904 However, that fix of course renders vimperator incompatible with versions of firefox older than revision "$REV_FF"; the next officially tagged, compatible version of firefox is: $ cd /path/to/firefox/mercurial/repository $ REVSET="first(sort(descendants($REV_FF) and tag(), date))" $ hg log --template '{latesttag}\n' -r "$REVSET" FIREFOX_AURORA_25_BASE Hence. this changeset updates the `install.rdf' to reflect that `25.0' is the new minimum required version for firefox.
1 parent db11b0a commit 3b90a60

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

vimperator/install.rdf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<em:targetApplication>
1616
<Description>
1717
<em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
18-
<em:minVersion>17.0</em:minVersion>
18+
<em:minVersion>25.0</em:minVersion>
1919
<em:maxVersion>29.0</em:maxVersion>
2020
</Description>
2121
</em:targetApplication>

0 commit comments

Comments
 (0)