Skip to content

Commit 401ba48

Browse files
committed
code review comments
1 parent 0399b59 commit 401ba48

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

common/content/buffer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1710,7 +1710,7 @@ const Buffer = Module("buffer", {
17101710

17111711
// NOTE: Array.from doesn't work here
17121712
let elements = [];
1713-
for (m in util.evaluateXPath(xpath)) {
1713+
for (let m in util.evaluateXPath(xpath)) {
17141714
if (m.getClientRects().length
17151715
&& (!(m instanceof HTMLIFrameElement) || Editor.windowIsEditable(m.contentWindow)))
17161716
elements.push(m);

common/content/commands.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1152,7 +1152,8 @@ const Commands = Module("commands", {
11521152
/* assert end */
11531153

11541154
return Object.keys(completeOptionMap)
1155-
.filter(k => (completer == completion[completeOptionMap[k]]))[0] || "custom";
1155+
.filter(k => (completer == completion[completeOptionMap[k]]))[0] ||
1156+
"custom";
11561157
} else {
11571158
return "";
11581159
}

vimperator/content/config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ var Config = Module("config", ConfigBase, {
293293
/* assert end */
294294

295295
let completions = [];
296-
for (i of util.range(0, result.matchCount)) {
296+
for (let i of util.range(0, result.matchCount)) {
297297
completions.push([result.getValueAt(i), result.getCommentAt(i), result.getImageAt(i)]);
298298
}
299299
context.completions = completions;

0 commit comments

Comments
 (0)