Skip to content

Commit afe333b

Browse files
committed
Remove unnecessary Iterator loop in history.get (#517)
This seems to be not necessary and it is causing issues particularly in firefox 47, there query is a "XPCWrappedNative_NoHelper" and we can't modify it which is what this loop tries to do. Wrapping it in a try/catch does fix the issue as well but removing it altogether seems to also fix it and seems that there are no adverse effects.
1 parent e65a566 commit afe333b

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

common/content/history.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ const History = Module("history", {
1717

1818
if (typeof filter == "string")
1919
filter = { searchTerms: filter };
20-
for (let [k, v] in Iterator(filter))
21-
query[k] = v;
20+
2221
options.sortingMode = options.SORT_BY_DATE_DESCENDING;
2322
options.resultType = options.RESULTS_AS_URI;
2423
if (maxItems > 0)

0 commit comments

Comments
 (0)