[lld] Remove redundant declarations (NFC) (llvm#166712)

kazutakahirata · vinay-deshmukh · commit c9679705d544 · 2025-11-08T15:13:35.000-05:00
In C++17, static constexpr members are implicitly inline, so they no
longer require an out-of-line definition.

Identified with readability-redundant-declaration.
diff --git a/lld/ELF/SyntheticSections.cpp b/lld/ELF/SyntheticSections.cpp
@@ -54,8 +54,6 @@ using llvm::support::endian::read32le;
 using llvm::support::endian::write32le;
 using llvm::support::endian::write64le;
 
-constexpr size_t MergeNoTailSection::numShards;
-
 static uint64_t readUint(Ctx &ctx, uint8_t *buf) {
   return ctx.arg.is64 ? read64(ctx, buf) : read32(ctx, buf);
 }

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,6 @@ using llvm::support::endian::read32le;`
`54`	`54`	`using llvm::support::endian::write32le;`
`55`	`55`	`using llvm::support::endian::write64le;`
`56`	`56`
`57`		`-constexpr size_t MergeNoTailSection::numShards;`
`58`		`-`
`59`	`57`	`static uint64_t readUint(Ctx &ctx, uint8_t *buf) {`
`60`	`58`	`return ctx.arg.is64 ? read64(ctx, buf) : read32(ctx, buf);`
`61`	`59`	`}`