fix(openapi): boolean "true" value in HttpOperation::openapi (api-platform#7003)

fixes api-platform#6993

Author: soyuka

src/OpenApi/Factory/OpenApiFactory.php

@@ -174,7 +174,7 @@ private function collectPaths(ApiResource $resource, ResourceMetadataCollection
         }
 
         foreach ($resource->getOperations() as $operationName => $operation) {
-            $resourceShortName = $operation->getShortName();
+            $resourceShortName = $operation->getShortName() ?? $operation;
             // No path to return
             if (null === $operation->getUriTemplate() && null === $operation->getRouteName()) {
                 continue;
@@ -187,7 +187,8 @@ private function collectPaths(ApiResource $resource, ResourceMetadataCollection
                 continue;
             }
 
-            $operationTag = ($openapiAttribute?->getExtensionProperties()[self::API_PLATFORM_TAG] ?? []);
+            // See https://github.com/api-platform/core/issues/6993 we would like to allow only `false` but as we typed `bool` we have this check
+            $operationTag = !\is_object($openapiAttribute) ? [] : ($openapiAttribute->getExtensionProperties()[self::API_PLATFORM_TAG] ?? []);
             if (!\is_array($operationTag)) {
                 $operationTag = [$operationTag];
             }
@@ -206,7 +207,7 @@ private function collectPaths(ApiResource $resource, ResourceMetadataCollection
             if ($this->routeCollection && $routeName && $route = $this->routeCollection->get($routeName)) {
                 $path = $route->getPath();
             } else {
-                $path = rtrim($operation->getRoutePrefix() ?? '', '/').'/'.ltrim($operation->getUriTemplate(), '/');
+                $path = rtrim($operation->getRoutePrefix() ?? '', '/').'/'.ltrim($operation->getUriTemplate() ?? '', '/');
             }
 
             $path = $this->getPath($path);

src/OpenApi/Tests/Factory/OpenApiFactoryTest.php

@@ -1296,4 +1296,54 @@ public function testInvoke(): void
         $this->assertNotNull($diamondPutOperation);
         $this->assertArrayNotHasKey('403', $diamondPutResponses);
     }
+
+    public function testGetExtensionPropertiesWithFalseValue(): void
+    {
+        $resourceNameCollectionFactory = $this->createMock(ResourceNameCollectionFactoryInterface::class);
+        $resourceCollectionMetadataFactory = $this->createMock(ResourceMetadataCollectionFactoryInterface::class);
+        $propertyNameCollectionFactory = $this->createMock(PropertyNameCollectionFactoryInterface::class);
+        $propertyMetadataFactory = $this->createMock(PropertyMetadataFactoryInterface::class);
+        $definitionNameFactory = new DefinitionNameFactory([]);
+
+        $resourceCollectionMetadata = new ResourceMetadataCollection(Dummy::class, [(new ApiResource(operations: [
+            (new Get())->withOpenapi(true)->withShortName('Dummy')->withName('api_dummies_get_collection')->withRouteName('api_dummies_get_collection'),
+        ]))->withClass(Dummy::class)]);
+
+        $resourceCollectionMetadataFactory
+            ->method('create')
+            ->willReturnCallback(fn (string $resourceClass): ResourceMetadataCollection => match ($resourceClass) {
+                default => new ResourceMetadataCollection($resourceClass, []),
+                Dummy::class => $resourceCollectionMetadata,
+            });
+
+        $resourceNameCollectionFactory->expects($this->once())
+            ->method('create')
+            ->willReturn(new ResourceNameCollection([Dummy::class]));
+
+        $propertyNameCollectionFactory->method('create')->willReturn(new PropertyNameCollection([]));
+
+        $schemaFactory = new SchemaFactory(
+            resourceMetadataFactory: $resourceCollectionMetadataFactory,
+            propertyNameCollectionFactory: $propertyNameCollectionFactory,
+            propertyMetadataFactory: $propertyMetadataFactory,
+            nameConverter: new CamelCaseToSnakeCaseNameConverter(),
+            definitionNameFactory: $definitionNameFactory,
+        );
+
+        $factory = new OpenApiFactory(
+            $resourceNameCollectionFactory,
+            $resourceCollectionMetadataFactory,
+            $propertyNameCollectionFactory,
+            $propertyMetadataFactory,
+            $schemaFactory,
+            null,
+            [],
+            new Options('Test API', 'This is a test API.', '1.2.3'),
+            new PaginationOptions(),
+            null,
+            ['json' => ['application/problem+json']]
+        );
+
+        $openApi = $factory->__invoke();
+    }
 }