Drop dead code from provide_latest_counterparty_commitment_tx

tnull · tnull · commit 468588f2ffca · 2024-11-01T10:26:46.000+01:00
We drop some dead code that unnecessarily allocates a `Vec` but does
nothing else.
diff --git a/lightning/src/chain/channelmonitor.rs b/lightning/src/chain/channelmonitor.rs
@@ -2855,12 +2855,6 @@ impl<Signer: EcdsaChannelSigner> ChannelMonitorImpl<Signer> {
 				self.their_cur_per_commitment_points = Some((commitment_number, their_per_commitment_point, None));
 			}
 		}
-		let mut htlcs = Vec::with_capacity(htlc_outputs.len());
-		for htlc in htlc_outputs {
-			if htlc.0.transaction_output_index.is_some() {
-				htlcs.push(htlc.0);
-			}
-		}
 	}
 
 	/// Informs this monitor of the latest holder (ie broadcastable) commitment transaction. The

Original file line number	Diff line number	Diff line change
`@@ -2855,12 +2855,6 @@ impl<Signer: EcdsaChannelSigner> ChannelMonitorImpl<Signer> {`
`2855`	`2855`	`self.their_cur_per_commitment_points = Some((commitment_number, their_per_commitment_point, None));`
`2856`	`2856`	`}`
`2857`	`2857`	`}`
`2858`		`- let mut htlcs = Vec::with_capacity(htlc_outputs.len());`
`2859`		`- for htlc in htlc_outputs {`
`2860`		`- if htlc.0.transaction_output_index.is_some() {`
`2861`		`- htlcs.push(htlc.0);`
`2862`		`- }`
`2863`		`- }`
`2864`	`2858`	`}`
`2865`	`2859`
`2866`	`2860`	`/// Informs this monitor of the latest holder (ie broadcastable) commitment transaction. The`