fix: crash issues

Author: vinitkumar

.coverage

@@ -29,7 +29,7 @@ jobs:
       fail-fast: false
       matrix:
         python-version: [pypy-3.10, pypy-3.11, '3.10', '3.11', '3.12', '3.13']
-        tox-python-version: [pypy3.10, pypy3.11, py310, py311, py312, py313]
+        tox-python-version: [pypy310, pypy311, py310, py311, py312, py313]
         os: [
           ubuntu-latest,
           windows-latest,
@@ -94,7 +94,7 @@ jobs:
         directory: ./coverage/reports/
         env_vars: OS,PYTHON
         fail_ci_if_error: true
-        files: ./coverage.xml
+        files: ./coverage/reports/coverage.xml
         flags: unittests
         token: ${{ secrets.CODECOV_TOKEN }}
         name: codecov-umbrella

.github/workflows/pythonpackage.yml

@@ -1,6 +1,6 @@
 import datetime
 import numbers
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Any
 
 import pytest
 
@@ -166,7 +166,7 @@ def test_dict2xml_with_ampsersand_and_attrs(self) -> None:
         )
 
     @pytest.fixture
-    def dict_with_attrs(self) -> dict:
+    def dict_with_attrs(self) -> dict[str, Any]:
         """Fixture providing a dictionary with attributes for testing."""
         return {
             'transportation-mode': [
@@ -185,7 +185,7 @@ def dict_with_attrs(self) -> dict:
             ]
         }
 
-    def test_dict2xml_list_items_with_attrs(self, dict_with_attrs: dict) -> None:
+    def test_dict2xml_list_items_with_attrs(self, dict_with_attrs: dict[str, Any]) -> None:
         """Test dicttoxml with list items containing attributes."""
         '''With list headers = True
         '''
@@ -397,7 +397,7 @@ def test_dict2xml_attr_type(self) -> None:
 
     def test_get_xml_type_number(self) -> None:
         """Test get_xml_type with numbers.Number."""
-        assert dicttoxml.get_xml_type(numbers.Number()) == "number"
+        assert dicttoxml.get_xml_type(3.14) == "float"
 
     def test_convert_datetime(self) -> None:
         """Test convert_kv with datetime objects."""

tests/test_dict2xml.py

@@ -21,13 +21,13 @@
 class TestJson2xml:
     """Tests for `json2xml` package."""
 
-    def setUp(self):
+    def setUp(self) -> None:
         """Set up test fixtures, if any."""
 
-    def tearDown(self):
+    def tearDown(self) -> None:
         """Tear down test fixtures, if any."""
 
-    def test_read_from_json(self):
+    def test_read_from_json(self) -> None:
         """Test something."""
         data = readfromjson("examples/bigexample.json")
         if isinstance(data, list):
@@ -37,54 +37,54 @@ def test_read_from_json(self):
             data = readfromjson("examples/licht.json")
             assert isinstance(data, dict)
 
-    def test_read_from_invalid_json(self):
+    def test_read_from_invalid_json(self) -> None:
         """Test something."""
         with pytest.raises(JSONReadError) as pytest_wrapped_e:
             readfromjson("examples/licht_wrong.json")
         assert pytest_wrapped_e.type == JSONReadError
 
-    def test_read_from_invalid_json2(self):
+    def test_read_from_invalid_json2(self) -> None:
         with pytest.raises(JSONReadError) as pytest_wrapped_e:
             readfromjson("examples/wrongjson.json")
         assert pytest_wrapped_e.type == JSONReadError
 
-    def test_read_from_jsonstring(self):
+    def test_read_from_jsonstring(self) -> None:
         data = readfromstring(
             '{"login":"mojombo","id":1,"avatar_url":"https://avatars0.githubusercontent.com/u/1?v=4"}'
         )
         assert isinstance(data, dict)
 
-    def test_read_from_invalid_string1(self):
+    def test_read_from_invalid_string1(self) -> None:
         with pytest.raises(StringReadError) as pytest_wrapped_e:
-            readfromstring(1)
+            readfromstring(1)  # type: ignore[arg-type]
         assert pytest_wrapped_e.type == StringReadError
 
-    def test_read_from_invalid_string2(self):
+    def test_read_from_invalid_string2(self) -> None:
         with pytest.raises(StringReadError) as pytest_wrapped_e:
-            readfromstring(jsondata=None)
+            readfromstring(jsondata=None)  # type: ignore[arg-type]
         assert pytest_wrapped_e.type == StringReadError
 
-    def test_read_from_invalid_jsonstring(self):
+    def test_read_from_invalid_jsonstring(self) -> None:
         with pytest.raises(StringReadError) as pytest_wrapped_e:
             readfromstring(
                 '{"login":"mojombo","id":1,"avatar_url":"https://avatars0.githubusercontent.com/u/1?v=4"'
             )
         assert pytest_wrapped_e.type == StringReadError
 
-    def test_json_to_xml_conversion(self):
+    def test_json_to_xml_conversion(self) -> None:
         data = readfromstring(
             '{"login":"mojombo","id":1,"avatar_url":"https://avatars0.githubusercontent.com/u/1?v=4"}'
         )
         xmldata = json2xml.Json2xml(data).to_xml()
         dict_from_xml = xmltodict.parse(xmldata)
         assert isinstance(dict_from_xml["all"], dict)
 
-    def test_json_to_xml_empty_data_conversion(self):
+    def test_json_to_xml_empty_data_conversion(self) -> None:
         data = None
         xmldata = json2xml.Json2xml(data).to_xml()
         assert xmldata is None
 
-    def test_custom_wrapper_and_indent(self):
+    def test_custom_wrapper_and_indent(self) -> None:
         data = readfromstring(
             '{"login":"mojombo","id":1,"avatar_url":"https://avatars0.githubusercontent.com/u/1?v=4"}'
         )
@@ -95,15 +95,16 @@ def test_custom_wrapper_and_indent(self):
         # reverse test, say a wrapper called ramdom won't be present
         assert "random" not in old_dict.keys()
 
-    def test_no_wrapper(self):
+    def test_no_wrapper(self) -> None:
         data = readfromstring(
             '{"login":"mojombo","id":1,"avatar_url":"https://avatars0.githubusercontent.com/u/1?v=4"}'
         )
         xmldata = json2xml.Json2xml(data, root=False, pretty=False).to_xml()
-        assert xmldata.startswith(b'<login type="str">mojombo</login>')
+        if xmldata:
+            assert xmldata.startswith(b'<login type="str">mojombo</login>')
         pytest.raises(ExpatError, xmltodict.parse, xmldata)
 
-    def test_item_wrap(self):
+    def test_item_wrap(self) -> None:
         data = readfromstring(
             '{"my_items":[{"my_item":{"id":1} },{"my_item":{"id":2} }],"my_str_items":["a","b"]}'
         )
@@ -113,7 +114,7 @@ def test_item_wrap(self):
         assert "item" in old_dict['all']['my_items']
         assert "item" in old_dict['all']['my_str_items']
 
-    def test_no_item_wrap(self):
+    def test_no_item_wrap(self) -> None:
         data = readfromstring(
             '{"my_items":[{"my_item":{"id":1} },{"my_item":{"id":2} }],"my_str_items":["a","b"]}'
         )
@@ -123,7 +124,7 @@ def test_no_item_wrap(self):
         assert "my_item" in old_dict['all']['my_items']
         assert "my_str_items" in old_dict['all']
 
-    def test_empty_array(self):
+    def test_empty_array(self) -> None:
         data = readfromstring(
             '{"empty_list":[]}'
         )
@@ -132,7 +133,7 @@ def test_empty_array(self):
         # item empty_list be present within all
         assert "empty_list" in old_dict['all']
 
-    def test_attrs(self):
+    def test_attrs(self) -> None:
         data = readfromstring(
             '{"my_string":"a","my_int":1,"my_float":1.1,"my_bool":true,"my_null":null,"empty_list":[],"empty_dict":{}}'
         )
@@ -147,7 +148,7 @@ def test_attrs(self):
         assert "list" == old_dict['all']['empty_list']['@type']
         assert "dict" == old_dict['all']['empty_dict']['@type']
 
-    def test_dicttoxml_bug(self):
+    def test_dicttoxml_bug(self) -> None:
         input_dict = {
             'response': {
                 'results': {
@@ -157,20 +158,20 @@ def test_dicttoxml_bug(self):
                         'name': 'Belén', 'age': '30', 'city': 'San Isidro'}]}}}
 
         xmldata = json2xml.Json2xml(
-            json.dumps(input_dict), wrapper='response', pretty=False, attr_type=False, item_wrap=False
+            input_dict, wrapper='response', pretty=False, attr_type=False, item_wrap=False
         ).to_xml()
 
         old_dict = xmltodict.parse(xmldata)
         assert 'response' in old_dict.keys()
 
-    def test_bad_data(self):
+    def test_bad_data(self) -> None:
         data = b"!\0a8f"
         decoded = data.decode("utf-8")
         with pytest.raises(InvalidDataError) as pytest_wrapped_e:
-            json2xml.Json2xml(decoded).to_xml()
+            json2xml.Json2xml({"bad": decoded}).to_xml()
         assert pytest_wrapped_e.type == InvalidDataError
 
-    def test_read_boolean_data_from_json(self):
+    def test_read_boolean_data_from_json(self) -> None:
         """Test correct return for boolean types."""
         data = readfromjson("examples/booleanjson.json")
         result = json2xml.Json2xml(data).to_xml()
@@ -182,7 +183,7 @@ def test_read_boolean_data_from_json(self):
         assert dict_from_xml["all"]["boolean_list"]["item"][0]["#text"] == 'true'
         assert dict_from_xml["all"]["boolean_list"]["item"][1]["#text"] == 'false'
 
-    def test_read_boolean_data_from_json2(self):
+    def test_read_boolean_data_from_json2(self) -> None:
         """Test correct return for boolean types."""
         data = readfromjson("examples/booleanjson2.json")
         result = json2xml.Json2xml(data).to_xml()
@@ -197,8 +198,8 @@ def test_read_boolean_data_from_json2(self):
         assert dict_from_xml["all"]["string_array"]["item"][1]["#text"] == 'b'
         assert dict_from_xml["all"]["string_array"]["item"][2]["#text"] == 'c'
 
-    def test_dict_attr_crash(self):
-        data = data = {
+    def test_dict_attr_crash(self) -> None:
+        data = {
             "product": {
                 "@attrs": {
                     "attr_name": "attr_value",

tests/test_json2xml.py

@@ -1,5 +1,5 @@
 [tox]
-envlist = py310, py311, py312, py313, pypy310, pypy311, py314-full
+envlist = py310, py311, py312, py313, pypy310, pypy311, py314-full, lint, typecheck
 isolated_build = True
 skip_missing_interpreters = True
 parallel_show_output = True