Changing order to "Complete" from admin dashboard does not trigger Order#enable_subscription

[femmestem]

If subscription order is initiated by customer on the front-end using manual payment or Spree::BogusGateway, and admin approves payment from the admin dashboard then the Order state is changed to "Complete" but subscription is not updated.

If Admin panel is changing order to "Complete" through ActiveRecord callbacks then State Machine is not invoked, so below is never triggered:

self.state_machine.after_transition to: :complete, do: :enable_subscriptions, if: :any_disabled_subscription?

See similar issue: https://stackoverflow.com/questions/22622254/spreeshipment-state-machine

[nishant-cyro]

@femmestem - Able to replicate the issue. Will fix them and let you know.

[AhmedAliIbrahim]

i think it doesn't trigger Order#enable_subscription on both admin and normal user !!
@nishant-cyro is there an estimate for the time you expect to solve it ?!

[femmestem]

@AhmedAliIbrahim When I place an order that is processed successfully, then it creates a subscription for me. However, if there's ANY error in the order process -- even if the error is in the subscription mail notification -- then subscription is not created. The issue is that Order#enable_subscription is only triggered by state_machine. Any operation for creating an order that doesn't invoke state_machine won't trigger Order#enable_subscription.

[nishant-cyro]

@AhmedAliIbrahim - Will fix it by EOW.