Skip to content

Commit fd36f45

Browse files
authored
Merge pull request #38 from vintasoftware/fix/rename-virtualmodel-user-field
Rename VirtualModel user field to avoid conflict
2 parents ddb2108 + b903a21 commit fd36f45

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [0.4.0]
8+
- Rename internal `user` attribute from `VirtualModel` to `_user` to avoid conflict with ForeignKey and OneToOneField fields with the same name
9+
710
## [0.3.0]
811

912
- Include `py.typed` file for type hints

django_virtual_models/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""Top-level package for django_virtual_models."""
22
import logging
33

4-
__version__ = "0.3.0"
4+
__version__ = "0.4.0"
55

66
# Good practice: https://docs.python-guide.org/writing/logging/#logging-in-a-library
77
logging.getLogger(__name__).addHandler(logging.NullHandler())

django_virtual_models/fields.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ def __init__(
199199
if to_attr is not None and lookup is None:
200200
raise InvalidVirtualModelParams("Always provide a `lookup` when providing a `to_attr`")
201201

202-
self.user = user
202+
self._user = user
203203
if manager is None:
204204
self.manager = self.Meta.model._default_manager
205205
self.model_cls = self.Meta.model
@@ -352,7 +352,7 @@ def get_optimized_queryset(
352352
new_qs = self._hydrate_queryset_with_nested_declared_fields(
353353
qs=qs,
354354
lookup_list=new_lookup_list,
355-
user=self.user,
355+
user=self._user,
356356
**kwargs,
357357
)
358358
new_qs = _defer_fields(

0 commit comments

Comments
 (0)