Skip to content

Commit 5f86483

Browse files
committed
Address missing code coverage
1 parent 885e3ac commit 5f86483

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

.travis.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ php:
1010

1111
cache:
1212
directories:
13-
- vendor
13+
- vendor
1414

1515
before_install:
1616
- export XDEBUG="/home/travis/.phpenv/versions/$(phpenv version-name)/etc/conf.d/xdebug.ini"
@@ -21,15 +21,11 @@ install:
2121
- travis_retry composer update -a --no-interaction
2222
- travis_retry wget https://scrutinizer-ci.com/ocular.phar
2323

24-
before_script:
25-
- if is_hhvm; then echo 'xdebug.enable = On' >> /etc/hhvm/php.ini; fi
26-
2724
script:
28-
- is_hhvm || mv -v "$XDEBUG.disabled" "$XDEBUG"
29-
- vendor/bin/phpunit --coverage-clover=coverage.clover --coverage-text
30-
- is_hhvm || mv -v "$XDEBUG" "$XDEBUG.disabled"
3125
- vendor/bin/phpcs --standard=PSR2 src tests
3226
- vendor/bin/php-cs-fixer fix -v --dry-run --allow-risky=yes --using-cache=no
27+
- if is_hhvm; then echo "xdebug.enable = On" >> /etc/hhvm/php.ini; else mv -v "$XDEBUG.disabled" "$XDEBUG"; fi
28+
- vendor/bin/phpunit --coverage-clover=coverage.clover --coverage-text
3329

3430
after_script:
3531
- is_hhvm || php ocular.phar code-coverage:upload --format=php-clover coverage.clover

src/AbstractJsonEncoder.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -414,12 +414,16 @@ private function getJsonErrorName($error)
414414
$matches = array_keys(get_defined_constants(), $error, true);
415415
$prefix = 'JSON_ERROR_';
416416
$prefixLength = strlen($prefix);
417+
$name = 'UNKNOWN_ERROR';
417418

418419
foreach ($matches as $match) {
419420
if (strncmp($match, $prefix, $prefixLength) === 0) {
420-
return $match;
421+
$name = $match;
422+
break;
421423
}
422424
}
425+
426+
return $name;
423427
}
424428

425429
/**

0 commit comments

Comments
 (0)