Skip to content

Commit ba4b377

Browse files
chleroygregkh
authored andcommitted
powerpc/64e: Fix wrong test in __ptep_test_and_clear_young()
[ Upstream commit 5ea0bba ] Commit 45201c8 ("powerpc/nohash: Remove hash related code from nohash headers.") replaced: if ((pte_val(*ptep) & (_PAGE_ACCESSED | _PAGE_HASHPTE)) == 0) return 0; By: if (pte_young(*ptep)) return 0; But it should be: if (!pte_young(*ptep)) return 0; Fix it. Fixes: 45201c8 ("powerpc/nohash: Remove hash related code from nohash headers.") Signed-off-by: Christophe Leroy <[email protected]> Signed-off-by: Michael Ellerman <[email protected]> Link: https://msgid.link/8bb7f06494e21adada724ede47a4c3d97e879d40.1695659959.git.christophe.leroy@csgroup.eu Signed-off-by: Sasha Levin <[email protected]>
1 parent dadb86f commit ba4b377

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/powerpc/include/asm/nohash/64/pgtable.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ static inline int __ptep_test_and_clear_young(struct mm_struct *mm,
216216
{
217217
unsigned long old;
218218

219-
if (pte_young(*ptep))
219+
if (!pte_young(*ptep))
220220
return 0;
221221
old = pte_update(mm, addr, ptep, _PAGE_ACCESSED, 0, 0);
222222
return (old & _PAGE_ACCESSED) != 0;

0 commit comments

Comments
 (0)