Skip to content

Commit 9ae4662

Browse files
committed
fixed tests, needed updated list of channels to include region_mask, etc
1 parent 9f62f66 commit 9ae4662

File tree

3 files changed

+60
-6
lines changed

3 files changed

+60
-6
lines changed

tests/data_model/test_result.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def test_plot_slice_2D(solver_output_path: Path, solver_output_simid_jobid: tupl
1616
sim_id, job_id = solver_output_simid_jobid
1717
result = Result(solver_output_dir=solver_output_path, sim_id=sim_id, job_id=job_id, zarr_dir=zarr_path)
1818

19-
expected_labels = ["C_cyt", "Ran_cyt", "RanC_cyt", "RanC_nuc", "J_r0"]
19+
expected_labels = ["region_mask", "t", "x", "y", "z", "C_cyt", "Ran_cyt", "RanC_cyt", "RanC_nuc", "J_r0"]
2020
assert [channel.label for channel in result.channel_data] == expected_labels
2121

2222
concentrations: NDArray2D = result.concentrations

tests/data_model/test_simulations.py

Lines changed: 58 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,30 @@ def test_sbml_model_parse_1d(sbml_spatial_model_1d_path: Path) -> None:
4444

4545
channels_orig = results_orig.channel_data
4646
channels_changed = results_changed.channel_data
47-
assert [ch.label for ch in channels_orig] == ["s0", "s1", "J_r0", "s0_init_umol_l_1", "s1_init_umol_l_1"]
48-
assert [ch.label for ch in channels_changed] == ["s0", "s1", "J_r0", "s0_init_umol_l_1", "s1_init_umol_l_1"]
47+
assert [ch.label for ch in channels_orig] == [
48+
"region_mask",
49+
"t",
50+
"x",
51+
"y",
52+
"z",
53+
"s0",
54+
"s1",
55+
"J_r0",
56+
"s0_init_umol_l_1",
57+
"s1_init_umol_l_1",
58+
]
59+
assert [ch.label for ch in channels_changed] == [
60+
"region_mask",
61+
"t",
62+
"x",
63+
"y",
64+
"z",
65+
"s0",
66+
"s1",
67+
"J_r0",
68+
"s0_init_umol_l_1",
69+
"s1_init_umol_l_1",
70+
]
4971
assert np.allclose(
5072
results_orig.concentrations[0, 0::10],
5173
np.array(
@@ -131,6 +153,11 @@ def test_sbml_model_parse_3d(sbml_spatial_model_3d_path: Path) -> None:
131153
channels_orig = results_orig.channel_data
132154
channels_changed = results_changed.channel_data
133155
assert [channel.label for channel in channels_orig] == [
156+
"region_mask",
157+
"t",
158+
"x",
159+
"y",
160+
"z",
134161
"s0",
135162
"s1",
136163
"s3",
@@ -140,6 +167,11 @@ def test_sbml_model_parse_3d(sbml_spatial_model_3d_path: Path) -> None:
140167
"s3_init_umol_l_1",
141168
]
142169
assert [channel.label for channel in channels_changed] == [
170+
"region_mask",
171+
"t",
172+
"x",
173+
"y",
174+
"z",
143175
"s0",
144176
"s1",
145177
"s3",
@@ -201,8 +233,30 @@ def test_vcml_model_parse_3d(vcml_spatial_model_1d_path: Path) -> None:
201233

202234
channels_orig = results_orig.channel_data
203235
channels_changed = results_changed.channel_data
204-
assert [channel.label for channel in channels_orig] == ["s0", "s1", "J_r0", "s0_init_uM", "s1_init_uM"]
205-
assert [channel.label for channel in channels_changed] == ["s0", "s1", "J_r0", "s0_init_uM", "s1_init_uM"]
236+
assert [channel.label for channel in channels_orig] == [
237+
"region_mask",
238+
"t",
239+
"x",
240+
"y",
241+
"z",
242+
"s0",
243+
"s1",
244+
"J_r0",
245+
"s0_init_uM",
246+
"s1_init_uM",
247+
]
248+
assert [channel.label for channel in channels_changed] == [
249+
"region_mask",
250+
"t",
251+
"x",
252+
"y",
253+
"z",
254+
"s0",
255+
"s1",
256+
"J_r0",
257+
"s0_init_uM",
258+
"s1_init_uM",
259+
]
206260
assert np.allclose(
207261
results_orig.concentrations[0, 0::10],
208262
np.array(

tests/simdata/test_vtk.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def test_vtk(solver_output_path: Path, solver_output_simid_jobid: tuple[int, int
2929
domain_names: list[str] = mesh.get_volume_domain_names()
3030
assert domain_names == ["Nucleus", "cytosol", "ec"]
3131
channel_names = [c.label for c in result.channel_data]
32-
assert channel_names == ["C_cyt", "Ran_cyt", "RanC_cyt", "RanC_nuc", "J_r0"]
32+
assert channel_names == ["region_mask", "t", "x", "y", "z", "C_cyt", "Ran_cyt", "RanC_cyt", "RanC_nuc", "J_r0"]
3333
times: list[float] = result.time_points
3434
assert times == [0.0, 0.25, 0.5, 0.75, 1.0]
3535

0 commit comments

Comments
 (0)