Skip to content

Commit 5f4973a

Browse files
authored
fix(parquet): More robust Buffer polyfill export (#3105)
1 parent d52f0e4 commit 5f4973a

File tree

6 files changed

+21
-13
lines changed

6 files changed

+21
-13
lines changed

modules/compression/src/lib/compression.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
// Copyright (c) vis.gl contributors
44

55
// Compression interface
6-
import {concatenateArrayBuffersAsync} from '@loaders.gl/loader-utils';
7-
import {registerJSModules} from '@loaders.gl/loader-utils';
6+
import {concatenateArrayBuffersAsync, registerJSModules} from '@loaders.gl/loader-utils';
87

98
/** Compression options */
109
export type CompressionOptions = {

modules/compression/src/lib/lz4-compression.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@
2626
/* eslint-disable max-statements */
2727

2828
// LZ4
29-
import {toArrayBuffer} from '@loaders.gl/loader-utils';
30-
import {registerJSModules, getJSModule} from '@loaders.gl/loader-utils';
29+
import {toArrayBuffer, registerJSModules, getJSModule} from '@loaders.gl/loader-utils';
3130
import type {CompressionOptions} from './compression';
3231
import {Compression} from './compression';
3332

modules/images/test/lib/category-api/parsed-image-api.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import test from 'tape-promise/tape';
22
import {load} from '@loaders.gl/core';
3-
import {ImageLoader, ImageType} from '@loaders.gl/images';
4-
5-
// PARSED IMAGE API
63
import {
4+
ImageLoader,
5+
ImageType,
6+
// PARSED IMAGE API
77
getDefaultImageType,
88
isImageTypeSupported,
99
isImage,

modules/mvt/src/lib/vector-tile/vector-tile-feature.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,13 @@
33
// Copyright vis.gl contributors
44

55
// This code is forked from https://github.com/mapbox/vector-tile-js under BSD 3-clause license.
6-
import {Feature} from '@loaders.gl/schema';
7-
import {FlatFeature, FlatIndexedGeometry, GeojsonGeometryInfo} from '@loaders.gl/schema';
6+
7+
import type {
8+
Feature,
9+
FlatFeature,
10+
FlatIndexedGeometry,
11+
GeojsonGeometryInfo
12+
} from '@loaders.gl/schema';
813
import Protobuf from 'pbf';
914
import {
1015
classifyRings,

modules/parquet/src/parquet-loader.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@ import {
2020
parseParquetFileInColumnarBatches
2121
} from './lib/parsers/parse-parquet-to-columns';
2222

23-
export {Buffer} from './polyfills/buffer/install-buffer-polyfill';
23+
// Note: The Buffer polyfill is quite fragile
24+
// For some reason, just exporting directly fails with some bundlers
25+
// export {Buffer} from './polyfills/buffer/install-buffer-polyfill';
26+
import {Buffer} from './polyfills/buffer/install-buffer-polyfill';
27+
export {Buffer};
2428

2529
// __VERSION__ is injected by babel-plugin-version-inline
2630
// @ts-ignore TS2304: Cannot find name '__VERSION__'.

modules/tile-converter/src/i3s-converter/helpers/batch-ids-extensions.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
/* eslint-disable camelcase */
2-
import {GLTFAccessorPostprocessed, GLTFMeshPrimitivePostprocessed} from '@loaders.gl/gltf';
32
import type {NumericArray} from '@loaders.gl/loader-utils';
43
import type {
4+
GLTFAccessorPostprocessed,
5+
GLTFMeshPrimitivePostprocessed,
56
GLTF_EXT_feature_metadata_FeatureIdTexture,
67
GLTF_EXT_feature_metadata_GLTF,
78
GLTF_EXT_feature_metadata_Primitive,
89
GLTF_EXT_mesh_features
910
} from '@loaders.gl/gltf';
11+
import {EXT_MESH_FEATURES, EXT_FEATURE_METADATA} from '@loaders.gl/gltf';
12+
import {Tiles3DTileContent} from '@loaders.gl/3d-tiles';
1013

1114
import {TypedArray} from '@math.gl/core';
1215
import {TextureImageProperties} from '../types';
1316
import {emod} from '@loaders.gl/math';
14-
import {EXT_MESH_FEATURES, EXT_FEATURE_METADATA} from '@loaders.gl/gltf';
15-
import {Tiles3DTileContent} from '@loaders.gl/3d-tiles';
1617

1718
/**
1819
* Get featureTexture by a metadata class.

0 commit comments

Comments
 (0)