Skip to content

Commit 9136655

Browse files
committed
[v8] Fix tests (#2475)
1 parent fc1d225 commit 9136655

File tree

17 files changed

+233
-62
lines changed

17 files changed

+233
-62
lines changed

modules/main/test/components/controls.spec.jsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ test('Controls', async t => {
1717
const mapRef = {current: null};
1818

1919
root.render(
20-
<Map ref={mapRef}>
20+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
2121
<AttributionControl />
2222
</Map>
2323
);
@@ -26,7 +26,7 @@ test('Controls', async t => {
2626
t.ok(rootContainer.querySelector('.mapboxgl-ctrl-attrib'), 'Rendered <AttributionControl />');
2727

2828
root.render(
29-
<Map ref={mapRef}>
29+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
3030
<FullscreenControl />
3131
</Map>
3232
);
@@ -35,7 +35,7 @@ test('Controls', async t => {
3535

3636
const geolocateControlRef = {current: null};
3737
root.render(
38-
<Map ref={mapRef}>
38+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
3939
<GeolocateControl ref={geolocateControlRef} />
4040
</Map>
4141
);
@@ -44,15 +44,15 @@ test('Controls', async t => {
4444
t.ok(geolocateControlRef.current, 'GeolocateControl created');
4545

4646
root.render(
47-
<Map ref={mapRef}>
47+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
4848
<NavigationControl />
4949
</Map>
5050
);
5151
await sleep(1);
5252
t.ok(rootContainer.querySelector('.mapboxgl-ctrl-zoom-in'), 'Rendered <NavigationControl />');
5353

5454
root.render(
55-
<Map ref={mapRef}>
55+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
5656
<ScaleControl />
5757
</Map>
5858
);

modules/main/test/components/layer.spec.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ test('Source/Layer', async t => {
3333
};
3434

3535
root.render(
36-
<Map ref={mapRef}>
36+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
3737
<Source id="my-data" type="geojson" data={geoJSON}>
3838
<Layer id="my-layer" {...pointLayer} />
3939
</Source>
@@ -45,7 +45,7 @@ test('Source/Layer', async t => {
4545
t.ok(layer, 'Layer is added');
4646

4747
root.render(
48-
<Map ref={mapRef}>
48+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
4949
<Source id="my-data" type="geojson" data={geoJSON}>
5050
<Layer id="my-layer" {...pointLayer2} />
5151
</Source>
@@ -55,7 +55,7 @@ test('Source/Layer', async t => {
5555
t.is(layer.visibility, 'none', 'Layer is updated');
5656

5757
root.render(
58-
<Map ref={mapRef} mapStyle={mapStyle}>
58+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')} mapStyle={mapStyle}>
5959
<Source id="my-data" type="geojson" data={geoJSON}>
6060
<Layer id="my-layer" {...pointLayer2} />
6161
</Source>
@@ -64,7 +64,7 @@ test('Source/Layer', async t => {
6464
await sleep(50);
6565
t.ok(mapRef.current.getLayer('my-layer'), 'Layer is added after style change');
6666

67-
root.render(<Map ref={mapRef} mapStyle={mapStyle} />);
67+
root.render(<Map ref={mapRef} mapLib={import('mapbox-gl-v1')} mapStyle={mapStyle} />);
6868
await sleep(1);
6969
t.notOk(mapRef.current.getSource('my-data'), 'Source is removed');
7070
t.notOk(mapRef.current.getLayer('my-layer'), 'Layer is removed');

modules/main/test/components/map.spec.jsx

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,12 @@ test('Map', async t => {
1616
const onLoad = () => onloadCalled++;
1717

1818
root.render(
19-
<Map ref={mapRef} initialViewState={{longitude: -100, latitude: 40, zoom: 4}} onLoad={onLoad} />
19+
<Map
20+
ref={mapRef}
21+
mapLib={import('mapbox-gl-v1')}
22+
initialViewState={{longitude: -100, latitude: 40, zoom: 4}}
23+
onLoad={onLoad}
24+
/>
2025
);
2126

2227
await waitForMapLoad(mapRef);
@@ -26,7 +31,16 @@ test('Map', async t => {
2631
t.is(mapRef.current.getCenter().lat, 40, 'latitude is set');
2732
t.is(mapRef.current.getZoom(), 4, 'zoom is set');
2833

29-
root.render(<Map ref={mapRef} longitude={-122} latitude={38} zoom={14} onLoad={onLoad} />);
34+
root.render(
35+
<Map
36+
ref={mapRef}
37+
mapLib={import('mapbox-gl-v1')}
38+
longitude={-122}
39+
latitude={38}
40+
zoom={14}
41+
onLoad={onLoad}
42+
/>
43+
);
3044
await sleep(1);
3145

3246
t.is(mapRef.current.getCenter().lng, -122, 'longitude is updated');
@@ -63,6 +77,7 @@ test('Map#uncontrolled', t => {
6377
root.render(
6478
<Map
6579
ref={mapRef}
80+
mapLib={import('mapbox-gl-v1')}
6681
initialViewState={{longitude: -100, latitude: 40, zoom: 4}}
6782
onLoad={onLoad}
6883
onRender={onRender}
@@ -90,6 +105,7 @@ test('Map#controlled#no-update', t => {
90105
root.render(
91106
<Map
92107
ref={mapRef}
108+
mapLib={import('mapbox-gl-v1')}
93109
longitude={-100}
94110
latitude={40}
95111
zoom={4}
@@ -129,6 +145,7 @@ test('Map#controlled#mirror-back', t => {
129145
return (
130146
<Map
131147
ref={mapRef}
148+
mapLib={import('mapbox-gl-v1')}
132149
{...viewState}
133150
onLoad={onLoad}
134151
onMove={e => setViewState(e.viewState)}
@@ -170,6 +187,7 @@ test('Map#controlled#delayed-update', t => {
170187
return (
171188
<Map
172189
ref={mapRef}
190+
mapLib={import('mapbox-gl-v1')}
173191
{...viewState}
174192
onLoad={onLoad}
175193
onMove={e => setTimeout(() => setViewState(e.viewState))}

modules/main/test/components/marker.spec.jsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ test('Marker', async t => {
1212
const mapRef = {current: null};
1313

1414
root.render(
15-
<Map ref={mapRef}>
15+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
1616
<Marker ref={markerRef} longitude={-122} latitude={38} />
1717
</Map>
1818
);
@@ -31,7 +31,7 @@ test('Marker', async t => {
3131
const rotationAlignment = marker.getRotationAlignment();
3232

3333
root.render(
34-
<Map ref={mapRef}>
34+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
3535
<Marker ref={markerRef} longitude={-122} latitude={38} offset={[0, 0]} />
3636
</Map>
3737
);
@@ -40,16 +40,16 @@ test('Marker', async t => {
4040

4141
let callbackType = '';
4242
root.render(
43-
<Map ref={mapRef}>
43+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
4444
<Marker
4545
ref={markerRef}
4646
longitude={-122}
4747
latitude={38}
4848
offset={[0, 1]}
4949
rotation={30}
5050
draggable
51-
pitchAlignment="viewport"
52-
rotationAlignment="viewport"
51+
pitchAlignment="map"
52+
rotationAlignment="map"
5353
onDragStart={() => (callbackType = 'dragstart')}
5454
onDrag={() => (callbackType = 'drag')}
5555
onDragEnd={() => (callbackType = 'dragend')}
@@ -71,13 +71,13 @@ test('Marker', async t => {
7171
marker.fire('dragend');
7272
t.is(callbackType, 'dragend', 'onDragEnd called');
7373

74-
root.render(<Map ref={mapRef} />);
74+
root.render(<Map ref={mapRef} mapLib={import('mapbox-gl-v1')} />);
7575
await sleep(1);
7676

7777
t.notOk(markerRef.current, 'marker is removed');
7878

7979
root.render(
80-
<Map ref={mapRef}>
80+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
8181
<Marker ref={markerRef} longitude={-100} latitude={40}>
8282
<div id="marker-content" />
8383
</Marker>

modules/main/test/components/popup.spec.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ test('Popup', async t => {
1111
const popupRef = {current: null};
1212

1313
root.render(
14-
<Map ref={mapRef}>
14+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
1515
<Popup ref={popupRef} longitude={-122} latitude={38} offset={[0, 10]}>
1616
You are here
1717
</Popup>
@@ -27,7 +27,7 @@ test('Popup', async t => {
2727
const {anchor, offset, maxWidth} = popup.options;
2828

2929
root.render(
30-
<Map ref={mapRef}>
30+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
3131
<Popup ref={popupRef} longitude={-122} latitude={38} offset={[0, 10]}>
3232
<div id="popup-content">You are here</div>
3333
</Popup>
@@ -39,7 +39,7 @@ test('Popup', async t => {
3939
t.ok(rootContainer.querySelector('#popup-content'), 'content is rendered');
4040

4141
root.render(
42-
<Map ref={mapRef}>
42+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
4343
<Popup
4444
ref={popupRef}
4545
longitude={-122}
@@ -59,7 +59,7 @@ test('Popup', async t => {
5959
t.not(maxWidth, popup.options.maxWidth, 'maxWidth is updated');
6060

6161
root.render(
62-
<Map ref={mapRef}>
62+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
6363
<Popup ref={popupRef} longitude={-122} latitude={38} className="classA">
6464
<div id="popup-content">You are here</div>
6565
</Popup>

modules/main/test/components/source.spec.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ test('Source/Layer', async t => {
1919
};
2020

2121
root.render(
22-
<Map ref={mapRef}>
22+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')}>
2323
<Source id="my-data" type="geojson" data={geoJSON} />
2424
</Map>
2525
);
@@ -28,23 +28,23 @@ test('Source/Layer', async t => {
2828
t.ok(mapRef.current.getSource('my-data'), 'Source is added');
2929

3030
root.render(
31-
<Map ref={mapRef} mapStyle={mapStyle}>
31+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')} mapStyle={mapStyle}>
3232
<Source id="my-data" type="geojson" data={geoJSON} />
3333
</Map>
3434
);
3535
await sleep(50);
3636
t.ok(mapRef.current.getSource('my-data'), 'Source is added after style change');
3737

3838
root.render(
39-
<Map ref={mapRef} mapStyle={mapStyle}>
39+
<Map ref={mapRef} mapLib={import('mapbox-gl-v1')} mapStyle={mapStyle}>
4040
<Source id="my-data" type="geojson" data={geoJSON2} />
4141
</Map>
4242
);
4343
await sleep(1);
4444
const sourceData = await mapRef.current.getSource('my-data')?._data;
4545
t.deepEqual(sourceData, geoJSON2, 'Source is updated');
4646

47-
root.render(<Map ref={mapRef} mapStyle={mapStyle} />);
47+
root.render(<Map ref={mapRef} mapLib={import('mapbox-gl-v1')} mapStyle={mapStyle} />);
4848
await sleep(1);
4949
t.notOk(mapRef.current.getSource('my-data'), 'Source is removed');
5050

modules/main/test/components/use-map.spec.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ test('useMap', async t => {
1616

1717
root.render(
1818
<MapProvider>
19-
<Map id="mapA" />
20-
<Map id="mapB" ref={mapRef} />
19+
<Map id="mapA" mapLib={import('mapbox-gl-v1')} />
20+
<Map id="mapB" ref={mapRef} mapLib={import('mapbox-gl-v1')} />
2121
<TestControl />
2222
</MapProvider>
2323
);
@@ -29,7 +29,7 @@ test('useMap', async t => {
2929

3030
root.render(
3131
<MapProvider>
32-
<Map id="mapA" />
32+
<Map id="mapA" mapLib={import('mapbox-gl-v1')} />
3333
<TestControl />
3434
</MapProvider>
3535
);

modules/react-mapbox/test/components/controls.spec.jsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,15 @@ import * as React from 'react';
1010
import {createRoot} from 'react-dom/client';
1111
import test from 'tape-promise/tape';
1212
import {sleep, waitForMapLoad} from '../utils/test-utils';
13+
import {MapboxAccessToken} from '../utils/token';
1314

1415
test('Controls', async t => {
1516
const rootContainer = document.createElement('div');
1617
const root = createRoot(rootContainer);
1718
const mapRef = {current: null};
1819

1920
root.render(
20-
<Map ref={mapRef}>
21+
<Map ref={mapRef} mapLib={import('mapbox-gl-v3')} mapboxAccessToken={MapboxAccessToken}>
2122
<AttributionControl />
2223
</Map>
2324
);
@@ -26,7 +27,7 @@ test('Controls', async t => {
2627
t.ok(rootContainer.querySelector('.mapboxgl-ctrl-attrib'), 'Rendered <AttributionControl />');
2728

2829
root.render(
29-
<Map ref={mapRef}>
30+
<Map ref={mapRef} mapLib={import('mapbox-gl-v3')} mapboxAccessToken={MapboxAccessToken}>
3031
<FullscreenControl />
3132
</Map>
3233
);
@@ -35,7 +36,7 @@ test('Controls', async t => {
3536

3637
const geolocateControlRef = {current: null};
3738
root.render(
38-
<Map ref={mapRef}>
39+
<Map ref={mapRef} mapLib={import('mapbox-gl-v3')} mapboxAccessToken={MapboxAccessToken}>
3940
<GeolocateControl ref={geolocateControlRef} />
4041
</Map>
4142
);
@@ -44,15 +45,15 @@ test('Controls', async t => {
4445
t.ok(geolocateControlRef.current, 'GeolocateControl created');
4546

4647
root.render(
47-
<Map ref={mapRef}>
48+
<Map ref={mapRef} mapLib={import('mapbox-gl-v3')} mapboxAccessToken={MapboxAccessToken}>
4849
<NavigationControl />
4950
</Map>
5051
);
5152
await sleep(1);
5253
t.ok(rootContainer.querySelector('.mapboxgl-ctrl-zoom-in'), 'Rendered <NavigationControl />');
5354

5455
root.render(
55-
<Map ref={mapRef}>
56+
<Map ref={mapRef} mapLib={import('mapbox-gl-v3')} mapboxAccessToken={MapboxAccessToken}>
5657
<ScaleControl />
5758
</Map>
5859
);

0 commit comments

Comments
 (0)