Skip to content

Commit a7f277b

Browse files
manuelrothchrisgervang
authored andcommitted
Improves Source#updateSource to use setTiles function if available (#2355)
1 parent ec7f8bf commit a7f277b

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

src/components/source.ts

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -75,19 +75,10 @@ function updateSource<SourceT extends ISource>(
7575
});
7676
} else if ('setCoordinates' in source && changedKeyCount === 1 && changedKey === 'coordinates') {
7777
source.setCoordinates((props as ImageSourceRaw).coordinates);
78-
} else if ('setUrl' in source) {
79-
// Added in 1.12.0:
80-
// vectorTileSource.setTiles
81-
// vectorTileSource.setUrl
82-
switch (changedKey) {
83-
case 'url':
84-
source.setUrl((props as VectorSourceRaw).url);
85-
break;
86-
case 'tiles':
87-
source.setTiles((props as VectorSourceRaw).tiles);
88-
break;
89-
default:
90-
}
78+
} else if ('setUrl' in source && changedKey === 'url') {
79+
source.setUrl((props as VectorSourceRaw).url);
80+
} else if ('setTiles' in source && changedKey === 'tiles') {
81+
source.setTiles((props as VectorSourceRaw).tiles);
9182
} else {
9283
// eslint-disable-next-line
9384
console.warn(`Unable to update <Source> prop: ${changedKey}`);

0 commit comments

Comments
 (0)