Skip to content

Commit b82b683

Browse files
fix: Remove explicit parameter names from @PathVariable annotations
- Change @PathVariable("agentId") to @PathVariable for agentId parameters - Change @PathVariable("threadId") to @PathVariable for threadId parameter - Follow established pattern from TicketTaskController.java - Addresses SonarCloud java:S6856 rule violations for @PathVariable binding Co-Authored-By: Vishal Mysore <visrow@gmail.com>
1 parent d014c0d commit b82b683

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/main/java/io/github/vishalmysore/acp/server/ACPController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ public interface ACPController {
1414
ResponseEntity<List<Agent>> searchAgents(@RequestBody AgentSearchRequest request);
1515

1616
@GetMapping("/agents/{agentId}")
17-
ResponseEntity<Agent> getAgent(@PathVariable("agentId") UUID agentId);
17+
ResponseEntity<Agent> getAgent(@PathVariable UUID agentId);
1818

1919
@GetMapping("/agents/{agentId}/descriptor")
20-
ResponseEntity<AgentACPDescriptor> getAgentDescriptor(@PathVariable("agentId") UUID agentId);
20+
ResponseEntity<AgentACPDescriptor> getAgentDescriptor(@PathVariable UUID agentId);
2121

2222
@PostMapping("/runs")
2323
ResponseEntity<AgentRun> createStatelessRun(@RequestBody RunCreateStateless request);
@@ -26,5 +26,5 @@ public interface ACPController {
2626
ResponseEntity<io.github.vishalmysore.acp.domain.Thread> createThread(@RequestBody Map<String, Object> metadata);
2727

2828
@PostMapping("/threads/{threadId}/runs")
29-
ResponseEntity<AgentRun> createStatefulRun(@PathVariable("threadId") UUID threadId, @RequestBody RunCreateStateful request);
29+
ResponseEntity<AgentRun> createStatefulRun(@PathVariable UUID threadId, @RequestBody RunCreateStateful request);
3030
}

src/main/java/io/github/vishalmysore/acp/server/ACPRestController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public ResponseEntity<List<Agent>> searchAgents(@RequestBody AgentSearchRequest
6767
}
6868

6969
@Override
70-
public ResponseEntity<Agent> getAgent(@PathVariable("agentId") UUID agentId) {
70+
public ResponseEntity<Agent> getAgent(@PathVariable UUID agentId) {
7171
log.info("Getting agent with ID: {}", agentId);
7272

7373
try {
@@ -90,7 +90,7 @@ public ResponseEntity<Agent> getAgent(@PathVariable("agentId") UUID agentId) {
9090
}
9191

9292
@Override
93-
public ResponseEntity<AgentACPDescriptor> getAgentDescriptor(@PathVariable("agentId") UUID agentId) {
93+
public ResponseEntity<AgentACPDescriptor> getAgentDescriptor(@PathVariable UUID agentId) {
9494
log.info("Getting agent descriptor for ID: {}", agentId);
9595

9696
try {
@@ -164,7 +164,7 @@ public ResponseEntity<io.github.vishalmysore.acp.domain.Thread> createThread(@Re
164164
}
165165

166166
@Override
167-
public ResponseEntity<AgentRun> createStatefulRun(@PathVariable("threadId") UUID threadId, @RequestBody RunCreateStateful request) {
167+
public ResponseEntity<AgentRun> createStatefulRun(@PathVariable UUID threadId, @RequestBody RunCreateStateful request) {
168168
log.info("Creating stateful run for thread {}: {}", threadId, request);
169169

170170
try {

0 commit comments

Comments
 (0)