Skip to content

Commit 338dba0

Browse files
authored
Merge pull request instructlab#744 from jeff-phillips-18/fixes
Fix typo in Experimental features nav item and q&a text overwrite
2 parents 0a6b5e0 + a946963 commit 338dba0

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

src/components/AppLayout.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ const AppLayout: React.FunctionComponent<IAppLayout> = ({ children, className })
108108
},
109109
isExperimentalEnabled && {
110110
path: '/experimental',
111-
label: 'Experimental fFeatures',
111+
label: 'Experimental features',
112112
children: [
113113
{ path: '/experimental/fine-tune/', label: 'Fine-tuning' },
114114
{ path: '/experimental/chat-eval/', label: 'Model chat eval' }

src/components/Contribute/Knowledge/KnowledgeSeedExamples/KnowledgeQuestionAnswerPair.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ const KnowledgeQuestionAnswerPair: React.FC<Props> = ({
4646
<Flex direction={{ default: 'column' }} gap={{ default: 'gapMd' }}>
4747
<FlexItem className="q-and-a-field">
4848
<TextArea
49+
className="q-and-a-field__text-area"
4950
autoResize
5051
rows={1}
5152
resizeOrientation="vertical"
@@ -55,7 +56,6 @@ const KnowledgeQuestionAnswerPair: React.FC<Props> = ({
5556
validated={questionAndAnswerPair.isQuestionValid === ValidatedOptions.error ? ValidatedOptions.error : ValidatedOptions.default}
5657
onChange={(_event, questionValue) => handleQuestionInputChange(index, questionValue)}
5758
onBlur={() => handleQuestionBlur(index)}
58-
style={{ paddingBottom: '1rem' }}
5959
/>
6060
{questionWordCount > 0 ? (
6161
<HelperText className="q-and-a-field__text-help">
@@ -75,6 +75,7 @@ const KnowledgeQuestionAnswerPair: React.FC<Props> = ({
7575
</FlexItem>
7676
<FlexItem className="q-and-a-field">
7777
<TextArea
78+
className="q-and-a-field__text-area"
7879
autoResize
7980
rows={1}
8081
resizeOrientation="vertical"
@@ -84,7 +85,6 @@ const KnowledgeQuestionAnswerPair: React.FC<Props> = ({
8485
validated={questionAndAnswerPair.isAnswerValid === ValidatedOptions.error ? ValidatedOptions.error : ValidatedOptions.default}
8586
onChange={(_event, answerValue) => handleAnswerInputChange(index, answerValue)}
8687
onBlur={() => handleAnswerBlur(index)}
87-
style={{ paddingBottom: '1rem' }}
8888
/>
8989
{answerWordCount > 0 ? (
9090
<HelperText className="q-and-a-field__text-help">

src/components/Contribute/Knowledge/KnowledgeSeedExamples/KnowledgeSeedExamples.scss

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,20 @@
2727
}
2828
.q-and-a-field {
2929
position: relative;
30+
&__text-area {
31+
textarea {
32+
padding-bottom: 1rem;
33+
&:not(:focus-visible) {
34+
outline: var(--pf-t--global--background--color--primary--default) auto 1px;
35+
}
36+
}
37+
}
3038
&__text-help {
3139
position: absolute;
32-
bottom: var(--pf-t--global--spacer--sm);
40+
bottom: calc(var(--pf-t--global--spacer--xs) + 3px);
3341
left: var(--pf-t--global--spacer--md);
42+
background-color: var(--pf-t--global--background--color--primary--default);
43+
width: calc(100% - 2 * var(--pf-t--global--spacer--lg));
3444
}
3545
}
3646
}

0 commit comments

Comments
 (0)