Skip to content

Commit 20a4b9a

Browse files
tklauseraboch
authored andcommitted
Clean logging up socket tests
Remove a stray fmt.Println in TestUnixSocketDiagInfo and convert any log.Fatal lines to testing.(*T).Fatal to properly fail tests.
1 parent 3d9b64d commit 20a4b9a

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

socket_test.go

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
package netlink
55

66
import (
7-
"fmt"
8-
"log"
97
"net"
108
"os/user"
119
"strconv"
@@ -66,11 +64,11 @@ func TestSocketGet(t *testing.T) {
6664
for _, v := range [...]string{"tcp4", "tcp6"} {
6765
addr, err := net.ResolveTCPAddr(v, "localhost:0")
6866
if err != nil {
69-
log.Fatal(err)
67+
t.Fatal(err)
7068
}
7169
l, err := net.ListenTCP(v, addr)
7270
if err != nil {
73-
log.Fatal(err)
71+
t.Fatal(err)
7472
}
7573
defer l.Close()
7674

@@ -86,11 +84,11 @@ func TestSocketGet(t *testing.T) {
8684
for _, v := range [...]string{"udp4", "udp6"} {
8785
addr, err := net.ResolveUDPAddr(v, "localhost:0")
8886
if err != nil {
89-
log.Fatal(err)
87+
t.Fatal(err)
9088
}
9189
l, err := net.ListenUDP(v, addr)
9290
if err != nil {
93-
log.Fatal(err)
91+
t.Fatal(err)
9492
}
9593
defer l.Close()
9694
conn, err := net.Dial(l.LocalAddr().Network(), l.LocalAddr().String())
@@ -108,11 +106,11 @@ func TestSocketDestroy(t *testing.T) {
108106

109107
addr, err := net.ResolveTCPAddr("tcp", "localhost:0")
110108
if err != nil {
111-
log.Fatal(err)
109+
t.Fatal(err)
112110
}
113111
l, err := net.ListenTCP("tcp", addr)
114112
if err != nil {
115-
log.Fatal(err)
113+
t.Fatal(err)
116114
}
117115
defer l.Close()
118116

@@ -171,7 +169,6 @@ func TestUnixSocketDiagInfo(t *testing.T) {
171169
}
172170

173171
for i, r := range result {
174-
fmt.Println(r.DiagMsg)
175172
if got := r.DiagMsg.Family; got != uint8(want) {
176173
t.Fatalf("%d: protocol family = %v, want %v", i, got, want)
177174
}

0 commit comments

Comments
 (0)