fix: add p-4 prefix expansion and deduplicate class name regex

Author: vitalis

.claude/skills/tw-mcp-critical-review/SKILL.md

@@ -21,34 +21,73 @@ Run a comprehensive review using multiple specialist agents in parallel.
 
 2. **Collect results** from all 4 agents.
 
-3. **Produce consolidated summary:**
+3. **Produce consolidated summary** (see format below).
+
+## Agent Prompt Rules
+
+**CRITICAL: Include these rules in EVERY agent prompt to prevent noise.**
+
+Each agent prompt MUST include the following section verbatim:
+
+```
+## What to Report
+
+Only report issues that meet ALL of these criteria:
+1. **Demonstrably wrong** — you can show it produces incorrect behavior, crashes, data loss, or security vulnerability
+2. **Reproducible** — you can describe concrete steps or inputs that trigger the issue
+3. **Not a trade-off** — the current approach was not an intentional design choice with documented rationale
+
+## What NOT to Report
+
+Do NOT report any of the following. These are explicitly banned:
+- "Consider adding..." / "Could be improved by..." — speculative improvements
+- Performance optimizations for code that handles < 10,000 items (premature optimization)
+- Missing tests for private/internal functions — only flag missing tests for PUBLIC API
+- "This could break if..." with hypothetical future scenarios that don't exist today
+- Code style preferences already handled by the project's linter (Biome)
+- Suggesting abstractions, wrappers, or classes for code that works fine as-is
+- Duplicated findings from previous review rounds that were evaluated and accepted
+- "Add a comment explaining..." — if the code is clear, it doesn't need a comment
+- Alternative approaches that are equally valid but not better ("you could also do X")
+- Module-level state that is intentional and correctly managed (e.g., caches, singletons)
+- Missing error handling for errors that cannot occur in practice
+
+## Severity Calibration
+
+- **CRITICAL**: Currently broken in production. Data loss, security hole, crash. Must have reproduction steps.
+- **MAJOR**: Demonstrable bug or correctness issue with concrete example. NOT "this might cause problems someday."
+- **MINOR**: Real code smell with a clear fix, NOT a suggestion or preference.
+
+## Hard Limits
+
+- Maximum 3 MAJOR issues per agent. If you find more, keep only the top 3 by impact.
+- Maximum 5 MINOR issues per agent. If you find more, keep only the top 5.
+- If you find 0 issues, return APPROVE with "No issues found." Do NOT invent issues to fill the template.
+- It is BETTER to return APPROVE than to pad findings with noise.
+```
+
+## Consolidated Summary Format
 
 ```
 ## Critical Review Summary
 
 ### Architecture: [ALIGNED / DRIFT DETECTED]
-
-[Key findings from ts-architect]
+[Only genuine architectural misalignment]
 
 ### Code Quality: [APPROVE / REQUEST CHANGES]
-
-[Key findings from ts-code-reviewer]
+[Only demonstrable bugs or correctness issues]
 
 ### Test Coverage: [SUFFICIENT / GAPS FOUND]
-
-[Key findings from ts-qa-developer]
+[Only missing tests for public API with real risk]
 
 ### Search Quality: [ACCEPTABLE / NEEDS TUNING]
-
-[Key findings from search quality check]
+[Only measurable search quality problems]
 
 ### Blockers
-
-[List any BLOCKER-severity issues]
+[List any CRITICAL-severity issues, or "None"]
 
 ### Action Items
-
-[Prioritized list of changes needed]
+[Deduplicated, prioritized list — max 5 items total across all agents]
 ```
 
 ## Success Criteria

src/storage/search.ts

@@ -1,6 +1,6 @@
 import type { Embedder } from "../pipeline/embedder.js";
 import type { TailwindVersion } from "../utils/config.js";
-import { expandQuery } from "../utils/query-expansion.js";
+import { TAILWIND_CLASS_RE, expandQuery } from "../utils/query-expansion.js";
 import { cosineSimilarity } from "../utils/similarity.js";
 import { type ChunkRow, type Database, blobToEmbedding } from "./database.js";
 
@@ -125,7 +125,8 @@ export async function hybridSearch(
   ]);
 
   // Boost keyword weight when query contains Tailwind class names (e.g., text-lg, pt-6, -mx-4)
-  const hasClassNames = /\b-?[a-z]+(?:-[a-z0-9]+)+\b/.test(query);
+  const hasClassNames = TAILWIND_CLASS_RE.test(query);
+  TAILWIND_CLASS_RE.lastIndex = 0; // Reset global regex state after .test()
   const weights: FusionWeights = hasClassNames
     ? { semantic: 1.0, keyword: 1.5 }
     : { semantic: 1.0, keyword: 1.0 };

src/utils/query-expansion.ts

@@ -7,7 +7,7 @@
  */
 
 /** Regex to detect Tailwind class names: hyphenated lowercase tokens like text-lg, grid-cols-3, -mx-4 */
-const TAILWIND_CLASS_RE = /\b-?[a-z]+(?:-[a-z0-9]+)+\b/g;
+export const TAILWIND_CLASS_RE = /\b-?[a-z]+(?:-[a-z0-9]+)+\b/g;
 
 /** Font size suffixes used by Tailwind's text-{size} utilities */
 const TEXT_SIZE_RE = /^text-(xs|sm|base|lg|xl|\d+xl)$/;
@@ -50,6 +50,7 @@ const PREFIX_MAP = new Map<string, string>([
 
   // ── Single-segment prefixes ────────────────────────────────────
   // Spacing
+  ["p", "padding"],
   ["px", "padding"],
   ["py", "padding"],
   ["pt", "padding"],

test/unit/query-expansion.test.ts

@@ -44,6 +44,11 @@ describe("Query Expansion", () => {
       expect(result).toContain("padding");
     });
 
+    it("expands p-4 to include padding", () => {
+      const result = expandQuery("p-4 class");
+      expect(result).toContain("padding");
+    });
+
     // ── Grid expansions ──────────────────────────────────────────
     it("expands grid-cols-3 to include grid template columns", () => {
       const result = expandQuery("grid-cols-3 tailwind grid");