latest cURL library has cmake hardcoded path for zstd

[bucanero]

in the latest curl library update, there's a hardcoded path /usr/local/vitasdk/arm-vita-eabi/lib/libzstd.a to zstd static library:

• file: curl/lib/cmake/CURL/CURLTargets.cmake (lines 58 - 67)

# Create imported target CURL::libcurl_static
add_library(CURL::libcurl_static STATIC IMPORTED)

set_target_properties(CURL::libcurl_static PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "CURL_STATICLIB"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_DIRECTORIES ""
  INTERFACE_LINK_LIBRARIES "\$<LINK_ONLY:OpenSSL::SSL>;\$<LINK_ONLY:OpenSSL::Crypto>;\$<LINK_ONLY:ZLIB::ZLIB>;/usr/local/vitasdk/arm-vita-eabi/lib/libzstd.a"
)

If any SDK user has installed vita-sdk on a different path, using CURL with cmake will fail to build the project due to missing library, even if you have libzstd installed with vdpm.

[bucanero]

Tagging @scribam @d3m3vilurr as I saw 85460c0 that might be related to this issue.

[isage]

This is cURL bug, that got fixed in 8.18.0
(or maybe not. needs testing)

[bucanero]

maybe we can bump to 8.18.0 or fix/patch the .cmake file in the vita-sdk package?

I think something like ${_IMPORT_PREFIX}/lib/libzstd.a could be enough to fix the path

[scribam]

I tried curl 8.18.0 and the issue seems fixed to me.

Here is the content of the same file:

# Create imported target CURL::libcurl_static
add_library(CURL::libcurl_static STATIC IMPORTED)

set_target_properties(CURL::libcurl_static PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "CURL_STATICLIB"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "\$<LINK_ONLY:ZLIB::ZLIB>;\$<LINK_ONLY:CURL::zstd>;\$<LINK_ONLY:ZLIB::ZLIB>"
)

Unfortunately, curl 8.18.0 requires OpenSSL 3 which does not exist for vitasdk.

[isage]

Well, the question is where CURL::zstd points.
Patch can be backported (it's 1 commit)

[bucanero]

Unfortunately, curl 8.18.0 requires OpenSSL 3 which does not exist for vitasdk.

idea on the side, we might want to use mbedTLS instead of openssl? on the pspsdk we have been using libcurl + mbedtls with good results, and I saw that vitasdk packages has an updated mbedtls version.

[isage]

Unfortunately, curl 8.18.0 requires OpenSSL 3 which does not exist for vitasdk.

idea on the side, we might want to use mbedTLS instead of openssl? on the pspsdk we have been using libcurl + mbedtls with good results, and I saw that vitasdk packages has an updated mbedtls version.

last attempt to do that didn't end well #241 (comment)

[bucanero]

for reference, I just went with this quick hack, and it fixed the issue on 8.17.0 using cmake:

• line 65 CURLTargets.cmake

  INTERFACE_LINK_LIBRARIES "\$<LINK_ONLY:OpenSSL::SSL>;\$<LINK_ONLY:OpenSSL::Crypto>;\$<LINK_ONLY:ZLIB::ZLIB>;${_IMPORT_PREFIX}/lib/libzstd.a"

[bucanero]

idea on the side, we might want to use mbedTLS instead of openssl? on the pspsdk we have been using libcurl + mbedtls with good results, and I saw that vitasdk packages has an updated mbedtls version.

last attempt to do that didn't end well #241 (comment)

A new libcurl + mbedtls package has been added in #379 . I'll try to integrate this mbedtls variant into one of my homebrew apps so I can do further testing.