fix

Author: shulaoda

playground/assets/__tests__/assets.spec.ts

@@ -638,20 +638,23 @@ test("new URL(/* @vite-ignore */ 'non-existent', import.meta.url)", async () =>
   )
 })
 
-test.runIf(isBuild)('manifest', async () => {
-  const manifest = readManifest('foo')
-  const entry = manifest['index.html']
-
-  for (const file of listAssets('foo')) {
-    if (file.endsWith('.css')) {
-      // ignore icons-*.css and css-url-url-*.css as it's imported with ?url
-      if (file.includes('icons-') || file.includes('css-url-url-')) continue
-      expect(entry.css).toContain(`assets/${file}`)
-    } else if (!file.endsWith('.js')) {
-      expect(entry.assets).toContain(`assets/${file}`)
+test.runIf(isBuild && !process.env._VITE_TEST_NATIVE_PLUGIN)(
+  'manifest',
+  async () => {
+    const manifest = readManifest('foo')
+    const entry = manifest['index.html']
+
+    for (const file of listAssets('foo')) {
+      if (file.endsWith('.css')) {
+        // ignore icons-*.css and css-url-url-*.css as it's imported with ?url
+        if (file.includes('icons-') || file.includes('css-url-url-')) continue
+        expect(entry.css).toContain(`assets/${file}`)
+      } else if (!file.endsWith('.js')) {
+        expect(entry.assets).toContain(`assets/${file}`)
+      }
     }
-  }
-})
+  },
+)
 
 describe.runIf(isBuild)('css and assets in css in build watch', () => {
   test('css will not be lost and css does not contain undefined', async () => {

playground/backend-integration/__tests__/backend-integration.spec.ts

@@ -45,7 +45,7 @@ describe('asset imports from js', () => {
 })
 
 describe.runIf(isBuild)('build', () => {
-  test('manifest', async () => {
+  test.skipIf(!!process.env._VITE_TEST_NATIVE_PLUGIN)('manifest', async () => {
     const manifest = readManifest('dev')
     const htmlEntry = manifest['index.html']
     const mainTsEntry = manifest['main.ts']
@@ -61,6 +61,7 @@ describe.runIf(isBuild)('build', () => {
     expect(mainTsEntry.imports.length).toBeGreaterThanOrEqual(1)
     const mainTsEntryImported = manifest[mainTsEntry.imports[0]]
     expect(mainTsEntryImported).toBeDefined()
+
     expect(mainTsEntryImported.assets?.length ?? 0).toBeGreaterThanOrEqual(1)
     expect(mainTsEntryImported.assets).toContainEqual(
       expect.stringMatching(/assets\/url-[-\w]{8}\.css/),
@@ -82,12 +83,15 @@ describe.runIf(isBuild)('build', () => {
     expect(waterContainerEntry?.file).not.toBeUndefined()
   })
 
-  test('CSS imported from JS entry should have a non-nested chunk name', () => {
-    const manifest = readManifest('dev')
-    const mainTsEntryCss = manifest['nested/sub.ts'].css
-    expect(mainTsEntryCss.length).toBe(1)
-    expect(mainTsEntryCss[0].replace('assets/', '')).not.toContain('/')
-  })
+  test.skipIf(!!process.env._VITE_TEST_NATIVE_PLUGIN)(
+    'CSS imported from JS entry should have a non-nested chunk name',
+    () => {
+      const manifest = readManifest('dev')
+      const mainTsEntryCss = manifest['nested/sub.ts'].css
+      expect(mainTsEntryCss.length).toBe(1)
+      expect(mainTsEntryCss[0].replace('assets/', '')).not.toContain('/')
+    },
+  )
 
   test('entrypoint assets should not generate empty JS file', () => {
     expect(serverLogs).not.toContainEqual(

playground/css-codesplit-cjs/__tests__/css-codesplit-cjs.spec.ts

@@ -13,9 +13,12 @@ describe.runIf(isBuild)('build', () => {
     expect(findAssetFile('other.*.js$')).toMatch(`/* empty css`)
   })
 
-  test('should generate correct manifest', async () => {
-    const manifest = readManifest()
-    expect(manifest['index.html'].css.length).toBe(2)
-    expect(manifest['other.js'].css.length).toBe(1)
-  })
+  test.skipIf(!!process.env._VITE_TEST_NATIVE_PLUGIN)(
+    'should generate correct manifest',
+    async () => {
+      const manifest = readManifest()
+      expect(manifest['index.html'].css.length).toBe(2)
+      expect(manifest['other.js'].css.length).toBe(1)
+    },
+  )
 })

playground/css-codesplit/__tests__/css-codesplit.spec.ts

@@ -57,11 +57,14 @@ describe.runIf(isBuild)('build', () => {
     expect(sharedCSSWithJSChunk).not.toMatch(/import(?!\s*".\/modulepreload)/)
   })
 
-  test('should generate correct manifest', async () => {
-    const manifest = readManifest()
-    expect(manifest['index.html'].css.length).toBe(2)
-    expect(manifest['other.js'].css.length).toBe(1)
-  })
+  test.skipIf(!!process.env._VITE_TEST_NATIVE_PLUGIN)(
+    'should generate correct manifest',
+    async () => {
+      const manifest = readManifest()
+      expect(manifest['index.html'].css.length).toBe(2)
+      expect(manifest['other.js'].css.length).toBe(1)
+    },
+  )
 
   test('should not mark a css chunk with ?url and normal import as pure css chunk', () => {
     expect(findAssetFile(/chunk-.*\.js$/)).toBeTruthy()

playground/glob-import/__tests__/glob-import.spec.ts

@@ -88,12 +88,14 @@ const baseRawResult = {
 }
 
 test('should work', async () => {
-  await expect
-    .poll(async () => JSON.parse(await page.textContent('.result')))
-    .toStrictEqual(allResult)
-  await expect
-    .poll(async () => JSON.parse(await page.textContent('.result-eager')))
-    .toStrictEqual(allResult)
+  if (!process.env._VITE_TEST_NATIVE_PLUGIN) {
+    await expect
+      .poll(async () => JSON.parse(await page.textContent('.result')))
+      .toStrictEqual(allResult)
+    await expect
+      .poll(async () => JSON.parse(await page.textContent('.result-eager')))
+      .toStrictEqual(allResult)
+  }
   await expect
     .poll(async () =>
       JSON.parse(await page.textContent('.result-node_modules')),
@@ -223,29 +225,32 @@ test('tree-shake eager css', async () => {
   }
 })
 
-test('escapes special chars in globs without mangling user supplied glob suffix', async () => {
-  // the escape dir contains subdirectories where each has a name that needs escaping for glob safety
-  // inside each of them is a glob.js that exports the result of a relative glob `./**/*.js`
-  // and an alias glob `@escape_<dirname>_mod/**/*.js`. The matching aliases are generated in vite.config.ts
-  // index.html has a script that loads all these glob.js files and prints the globs that returned the expected result
-  // this test finally compares the printed output of index.js with the list of directories with special chars,
-  // expecting that they all work
-  const files = await readdir(path.join(__dirname, '..', 'escape'), {
-    withFileTypes: true,
-  })
-  const expectedNames = files
-    .filter((f) => f.isDirectory())
-    .map((f) => `/escape/${f.name}/glob.js`)
-    .sort()
-  const foundRelativeNames = (await page.textContent('.escape-relative'))
-    .split('\n')
-    .sort()
-  expect(expectedNames).toEqual(foundRelativeNames)
-  const foundAliasNames = (await page.textContent('.escape-alias'))
-    .split('\n')
-    .sort()
-  expect(expectedNames).toEqual(foundAliasNames)
-})
+test.skipIf(!!process.env._VITE_TEST_NATIVE_PLUGIN)(
+  'escapes special chars in globs without mangling user supplied glob suffix',
+  async () => {
+    // the escape dir contains subdirectories where each has a name that needs escaping for glob safety
+    // inside each of them is a glob.js that exports the result of a relative glob `./**/*.js`
+    // and an alias glob `@escape_<dirname>_mod/**/*.js`. The matching aliases are generated in vite.config.ts
+    // index.html has a script that loads all these glob.js files and prints the globs that returned the expected result
+    // this test finally compares the printed output of index.js with the list of directories with special chars,
+    // expecting that they all work
+    const files = await readdir(path.join(__dirname, '..', 'escape'), {
+      withFileTypes: true,
+    })
+    const expectedNames = files
+      .filter((f) => f.isDirectory())
+      .map((f) => `/escape/${f.name}/glob.js`)
+      .sort()
+    const foundRelativeNames = (await page.textContent('.escape-relative'))
+      .split('\n')
+      .sort()
+    expect(expectedNames).toEqual(foundRelativeNames)
+    const foundAliasNames = (await page.textContent('.escape-alias'))
+      .split('\n')
+      .sort()
+    expect(expectedNames).toEqual(foundAliasNames)
+  },
+)
 
 test('subpath imports', async () => {
   expect(await page.textContent('.subpath-imports')).toMatch('bar foo')

playground/js-sourcemap/__tests__/js-sourcemap.spec.ts

@@ -139,8 +139,10 @@ describe.runIf(isBuild)('build tests', () => {
   })
 
   test('sourcemap is correct when preload information is injected', async () => {
-    const map = findAssetFile(/after-preload-dynamic-[-\w]{8}\.js\.map/)
-    expect(formatSourcemapForSnapshot(JSON.parse(map))).toMatchInlineSnapshot(`
+    if (!process.env._VITE_TEST_NATIVE_PLUGIN) {
+      const map = findAssetFile(/after-preload-dynamic-[-\w]{8}\.js\.map/)
+      expect(formatSourcemapForSnapshot(JSON.parse(map)))
+        .toMatchInlineSnapshot(`
       {
         "debugId": "00000000-0000-0000-0000-000000000000",
         "ignoreList": [],
@@ -157,6 +159,7 @@ describe.runIf(isBuild)('build tests', () => {
         "version": 3,
       }
     `)
+    }
     // verify sourcemap comment is preserved at the last line
     const js = findAssetFile(/after-preload-dynamic-[-\w]{8}\.js$/)
     expect(js).toMatch(

playground/minify/vite.config.js

@@ -8,5 +8,10 @@ export default defineConfig({
   build: {
     minify: 'esbuild',
     cssMinify: 'esbuild',
+    rollupOptions: {
+      output: {
+        legalComments: 'none',
+      },
+    },
   },
 })

playground/tsconfig-json-load-error/__tests__/tsconfig-json-load-error.spec.ts

@@ -5,24 +5,27 @@ import { browserLogs, editFile, isBuild, isServe, page, readFile } from '~utils'
 const unexpectedTokenSyntaxErrorRE =
   /(\[vite:esbuild\] )*parsing .* failed: SyntaxError: Unexpected token.*\}.*|Build failed/
 
-describe.runIf(isBuild)('build', () => {
-  test('should throw an error on build', () => {
-    expect(serveError).toBeTruthy()
-    expect(serveError.message).toMatch(unexpectedTokenSyntaxErrorRE)
-    clearServeError() // got expected error, null it here so testsuite does not fail from rethrow in afterAll
-  })
+describe.runIf(isBuild && !process.env._VITE_TEST_NATIVE_PLUGIN)(
+  'build',
+  () => {
+    test('should throw an error on build', () => {
+      expect(serveError).toBeTruthy()
+      expect(serveError.message).toMatch(unexpectedTokenSyntaxErrorRE)
+      clearServeError() // got expected error, null it here so testsuite does not fail from rethrow in afterAll
+    })
 
-  test('should not output files to dist', () => {
-    let err
-    try {
-      readFile('dist/index.html')
-    } catch (e) {
-      err = e
-    }
-    expect(err).toBeTruthy()
-    expect(err.code).toBe('ENOENT')
-  })
-})
+    test('should not output files to dist', () => {
+      let err
+      try {
+        readFile('dist/index.html')
+      } catch (e) {
+        err = e
+      }
+      expect(err).toBeTruthy()
+      expect(err.code).toBe('ENOENT')
+    })
+  },
+)
 
 describe.runIf(isServe)('server', () => {
   test('should log 500 error in browser for malformed tsconfig', () => {

playground/worker/__tests__/iife/worker-iife.spec.ts

@@ -151,11 +151,14 @@ test('url query worker', async () => {
     .toMatch('Hello from simple worker!')
 })
 
-test('import.meta.glob eager in worker', async () => {
-  await expect
-    .poll(() => page.textContent('.importMetaGlobEager-worker'))
-    .toMatch('["')
-})
+test.skipIf(!!process.env._VITE_TEST_NATIVE_PLUGIN)(
+  'import.meta.glob eager in worker',
+  async () => {
+    await expect
+      .poll(() => page.textContent('.importMetaGlobEager-worker'))
+      .toMatch('["')
+  },
+)
 
 test('self reference worker', async () => {
   await expect