fix: some isBuild using production mode

Author: underfin

packages/vite/src/node/config.ts

@@ -1273,7 +1273,7 @@ export async function resolveConfig(
 
   const [prePlugins, normalPlugins, postPlugins] = sortUserPlugins(rawPlugins)
 
-  const isBuild = command === 'build'
+  const isBuild = mode === 'production'
 
   // run config hooks
   const userPlugins = [...prePlugins, ...normalPlugins, ...postPlugins]

packages/vite/src/node/idResolver.ts

@@ -66,7 +66,7 @@ export function createIdResolver(
                 {
                   root: config.root,
                   isProduction: config.isProduction,
-                  isBuild: config.command === 'build',
+                  isBuild: config.mode === 'production',
                   asSrc: true,
                   preferRelative: false,
                   tryIndex: true,
@@ -80,7 +80,7 @@ export function createIdResolver(
                 resolvePlugin({
                   root: config.root,
                   isProduction: config.isProduction,
-                  isBuild: config.command === 'build',
+                  isBuild: config.mode === 'production',
                   asSrc: true,
                   preferRelative: false,
                   tryIndex: true,

packages/vite/src/node/plugins/assetImportMetaUrl.ts

@@ -37,7 +37,7 @@ export function assetImportMetaUrlPlugin(config: ResolvedConfig): Plugin {
     ...config.resolve,
     root: config.root,
     isProduction: config.isProduction,
-    isBuild: true, // config.command === 'build'
+    isBuild: config.mode === 'production',
     packageCache: config.packageCache,
     asSrc: true,
   }

packages/vite/src/node/plugins/css.ts

@@ -296,7 +296,7 @@ const cssUrlAssetRE = /__VITE_CSS_URL__([\da-f]+)__/g
  * Plugin applied before user plugins
  */
 export function cssPlugin(config: ResolvedConfig): Plugin {
-  // const isBuild = config.command === 'build'
+  const isBuild = config.mode === 'production'
   let moduleCache: Map<string, Record<string, string>>
 
   const idResolver = createBackCompatIdResolver(config, {
@@ -353,15 +353,15 @@ export function cssPlugin(config: ResolvedConfig): Plugin {
 
           // *.css?url
           // in dev, it's handled by assets plugin.
-          // if (isBuild) {
-          id = injectQuery(removeUrlQuery(id), 'transform-only')
-          return (
-            `import ${JSON.stringify(id)};` +
-            `export default "__VITE_CSS_URL__${Buffer.from(id).toString(
-              'hex',
-            )}__"`
-          )
-          // }
+          if (isBuild) {
+            id = injectQuery(removeUrlQuery(id), 'transform-only')
+            return (
+              `import ${JSON.stringify(id)};` +
+              `export default "__VITE_CSS_URL__${Buffer.from(id).toString(
+                'hex',
+              )}__"`
+            )
+          }
         }
       },
     },

packages/vite/src/node/plugins/define.ts

@@ -12,7 +12,7 @@ const importMetaEnvMarker = '__vite_import_meta_env__'
 const importMetaEnvKeyReCache = new Map<string, RegExp>()
 
 export function definePlugin(config: ResolvedConfig): Plugin {
-  // const isBuild = config.command === 'build'
+  const isBuild = config.mode === 'production'
   const isBuildLib = config.build.lib
 
   // ignore replace process.env in lib build
@@ -33,17 +33,17 @@ export function definePlugin(config: ResolvedConfig): Plugin {
   const importMetaKeys: Record<string, string> = {}
   const importMetaEnvKeys: Record<string, string> = {}
   const importMetaFallbackKeys: Record<string, string> = {}
-  // if (isBuild) {
-  importMetaKeys['import.meta.hot'] = `undefined`
-  for (const key in config.env) {
-    const val = JSON.stringify(config.env[key])
-    importMetaKeys[`import.meta.env.${key}`] = val
-    importMetaEnvKeys[key] = val
+  if (isBuild) {
+    importMetaKeys['import.meta.hot'] = `undefined`
+    for (const key in config.env) {
+      const val = JSON.stringify(config.env[key])
+      importMetaKeys[`import.meta.env.${key}`] = val
+      importMetaEnvKeys[key] = val
+    }
+    // these will be set to a proper value in `generatePattern`
+    importMetaKeys['import.meta.env.SSR'] = `undefined`
+    importMetaFallbackKeys['import.meta.env'] = `undefined`
   }
-  // these will be set to a proper value in `generatePattern`
-  importMetaKeys['import.meta.env.SSR'] = `undefined`
-  importMetaFallbackKeys['import.meta.env'] = `undefined`
-  // }
 
   function generatePattern(environment: Environment) {
     const keepProcessEnv = environment.config.keepProcessEnv