chore: use advancedChunks instead of manualChunks

Author: sapphi-red

playground/css-codesplit/__tests__/css-codesplit-consistent.spec.ts

@@ -8,8 +8,8 @@ beforeEach(async () => {
 for (let i = 0; i < 5; i++) {
   describe.runIf(isBuild)('css-codesplit build', () => {
     test('should be consistent with same content', () => {
-      expect(findAssetFile(/style-.+\.css/)).toMatch('h2{color:#00f}')
-      expect(findAssetFile(/style2-.+\.css/)).toBe('')
+      expect(findAssetFile(/style2-.+\.css/)).toMatch('h2{color:#00f}')
+      expect(findAssetFile(/style-.+\.css/)).toBe('')
     })
   })
 }

playground/css-codesplit/vite.config.js

@@ -13,11 +13,20 @@ export default defineConfig({
         'shared-css-no-js': resolve(__dirname, 'shared-css-no-js.html'),
       },
       output: {
-        manualChunks(id) {
-          // make `chunk.css` it's own chunk for easier testing of pure css chunks
-          if (id.includes('chunk.css')) {
-            return 'chunk'
-          }
+        // manualChunks(id) {
+        //   // make `chunk.css` it's own chunk for easier testing of pure css chunks
+        //   if (id.includes('chunk.css')) {
+        //     return 'chunk'
+        //   }
+        // },
+        advancedChunks: {
+          groups: [
+            // make `chunk.css` it's own chunk for easier testing of pure css chunks
+            {
+              name: 'chunk',
+              test: 'chunk.css',
+            },
+          ],
         },
       },
     },

playground/js-sourcemap/__tests__/js-sourcemap.spec.ts

@@ -140,7 +140,7 @@ describe.runIf(isBuild)('build tests', () => {
     expect(formatSourcemapForSnapshot(JSON.parse(map))).toMatchInlineSnapshot(`
       {
         "ignoreList": [],
-        "mappings": ";+8BAAA,OAAO,2BAAuB,EAAC,wBAE/B,QAAQ,IAAI,uBAAuB",
+        "mappings": ";4jCAAA,OAAO,6BAAuB,wBAE9B,QAAQ,IAAI",
         "sources": [
           "../../after-preload-dynamic.js",
         ],
@@ -156,7 +156,7 @@ describe.runIf(isBuild)('build tests', () => {
     // verify sourcemap comment is preserved at the last line
     const js = findAssetFile(/after-preload-dynamic-[-\w]{8}\.js$/)
     expect(js).toMatch(
-      /\n\/\/# sourceMappingURL=after-preload-dynamic-[-\w]{8}\.js\.map\n$/,
+      /\n\/\/# sourceMappingURL=after-preload-dynamic-[-\w]{8}\.js\.map\n?$/,
     )
   })
 
@@ -177,7 +177,7 @@ describe.runIf(isBuild)('build tests', () => {
     const map = findAssetFile(/with-define-object.*\.js\.map/)
     expect(formatSourcemapForSnapshot(JSON.parse(map))).toMatchInlineSnapshot(`
       {
-        "mappings": "qBAEA,SAASA,GAAO,CACJC,GACZ,CAEA,SAASA,GAAY,CAEX,QAAA,MAAM,qBAAsBC,CAAkB,CACxD,CAEAF,EAAK",
+        "mappings": "qBAEA,SAAS,GAAO,CACd,EAAA,CACF,CAEA,SAAS,GAAY,CAEnB,QAAQ,MAAM,qBAAsB,CAAA,CACtC,CAEA,EAAA",
         "sources": [
           "../../with-define-object.ts",
         ],

playground/js-sourcemap/vite.config.js

@@ -11,19 +11,33 @@ export default defineConfig({
     sourcemap: true,
     rollupOptions: {
       output: {
-        manualChunks(name) {
-          if (name.endsWith('after-preload-dynamic.js')) {
-            return 'after-preload-dynamic'
-          }
-          if (name.endsWith('after-preload-dynamic-hashbang.js')) {
-            return 'after-preload-dynamic-hashbang'
-          }
-          if (name.endsWith('after-preload-dynamic-no-dep.js')) {
-            return 'after-preload-dynamic-no-dep'
-          }
-          if (name.includes('with-define-object')) {
-            return 'with-define-object'
-          }
+        // manualChunks(name) {
+        //   if (name.endsWith('after-preload-dynamic.js')) {
+        //     return 'after-preload-dynamic'
+        //   }
+        //   if (name.endsWith('after-preload-dynamic-hashbang.js')) {
+        //     return 'after-preload-dynamic-hashbang'
+        //   }
+        //   if (name.endsWith('after-preload-dynamic-no-dep.js')) {
+        //     return 'after-preload-dynamic-no-dep'
+        //   }
+        //   if (name.includes('with-define-object')) {
+        //     return 'with-define-object'
+        //   }
+        // },
+        advancedChunks: {
+          groups: [
+            { name: 'after-preload-dynamic', test: 'after-preload-dynamic.js' },
+            {
+              name: 'after-preload-dynamic-hashbang',
+              test: 'after-preload-dynamic-hashbang.js',
+            },
+            {
+              name: 'after-preload-dynamic-no-dep',
+              test: 'after-preload-dynamic-no-dep.js',
+            },
+            { name: 'with-define-object', test: 'with-define-object' },
+          ],
         },
         banner(chunk) {
           if (chunk.name.endsWith('after-preload-dynamic-hashbang')) {

vitest.config.e2e.ts

@@ -18,12 +18,10 @@ export default defineConfig({
       ...(isBuild
         ? [
             './playground/backend-integration/**/*.spec.[tj]s', // https://github.com/rolldown/rolldown/issues/2207
-            './playground/css-codesplit/**/*.spec.[tj]s', // manualChunks
             './playground/css-dynamic-import/**/*.spec.[tj]s', // https://github.com/rolldown/rolldown/issues/1842
             './playground/dynamic-import/**/*.spec.[tj]s', // https://github.com/rolldown/rolldown/issues/1842, https://github.com/rolldown/rolldown/issues/1843
             './playground/external/**/*.spec.[tj]s', // https://github.com/rolldown/rolldown/issues/2041
             './playground/glob-import/**/*.spec.[tj]s', // remove empty CSS generate chunk https://github.com/rolldown/rolldown/issues/1842
-            './playground/js-sourcemap/**/*.spec.[tj]s', // manualChunks
             './playground/lib/**/*.spec.[tj]s', // umd format
             './playground/object-hooks/**/*.spec.[tj]s', // object hook sequential
             './playground/optimize-deps/**/*.spec.[tj]s', // https://github.com/rolldown/rolldown/issues/2031