Skip to content

Commit 1fe07d3

Browse files
authored
ci: run tests on Node 24 as well (vitejs#20049)
1 parent 94cd0f9 commit 1fe07d3

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
strategy:
6464
matrix:
6565
os: [ubuntu-latest]
66-
node_version: [20, 22]
66+
node_version: [20, 22, 24]
6767
include:
6868
# Active LTS + other OS
6969
- os: macos-latest

packages/vite/src/node/__tests__/runnerImport.spec.ts

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ import { loadConfigFromFile } from 'vite'
44
import { runnerImport } from '../ssr/runnerImport'
55
import { slash } from '../../shared/utils'
66

7+
const [nvMajor, nvMinor] = process.versions.node.split('.').map(Number)
8+
const isTypeStrippingSupported =
9+
(nvMajor === 23 && nvMinor >= 6) || nvMajor >= 24
10+
711
describe('importing files using inlined environment', () => {
812
const fixture = (name: string) =>
913
resolve(import.meta.dirname, './fixtures/runner-import', name)
@@ -51,15 +55,17 @@ describe('importing files using inlined environment', () => {
5155
])
5256

5357
// confirm that it fails with a bundle approach
54-
await expect(async () => {
55-
const root = resolve(import.meta.dirname, './fixtures/runner-import')
56-
await loadConfigFromFile(
57-
{ mode: 'production', command: 'serve' },
58-
resolve(root, './vite.config.outside-pkg-import.mts'),
59-
root,
60-
'silent',
61-
)
62-
}).rejects.toThrow('Unknown file extension ".ts"')
58+
if (!isTypeStrippingSupported) {
59+
await expect(async () => {
60+
const root = resolve(import.meta.dirname, './fixtures/runner-import')
61+
await loadConfigFromFile(
62+
{ mode: 'production', command: 'serve' },
63+
resolve(root, './vite.config.outside-pkg-import.mts'),
64+
root,
65+
'silent',
66+
)
67+
}).rejects.toThrow('Unknown file extension ".ts"')
68+
}
6369
})
6470

6571
test('dynamic import', async () => {

0 commit comments

Comments
 (0)