Skip to content

Commit 618dcb1

Browse files
committed
chore: enable some define tests
1 parent ae4c1f7 commit 618dcb1

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

packages/vite/src/node/__tests__/plugins/define.spec.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,7 @@ describe('definePlugin', () => {
8585
)
8686
})
8787

88-
// NOTE: skipped because of https://github.com/oxc-project/oxc/issues/7594
89-
test.skip('preserve import.meta.env.UNKNOWN with override', async () => {
88+
test('preserve import.meta.env.UNKNOWN with override', async () => {
9089
const transform = await createDefinePluginTransform({
9190
'import.meta.env.UNKNOWN': 'import.meta.env.UNKNOWN',
9291
})

playground/define/__tests__/define.spec.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { expect, test } from 'vitest'
22
import viteConfig from '../vite.config'
3-
import { isBuild, page } from '~utils'
3+
import { page } from '~utils'
44

55
const defines = viteConfig.define
66
const envDefines = viteConfig.environments.client.define
@@ -26,12 +26,9 @@ test('string', async () => {
2626
expect(await page.textContent('.env-var')).toBe(
2727
JSON.parse(defines['process.env.SOMEVAR']),
2828
)
29-
// NOTE: skipped because of https://github.com/oxc-project/oxc/issues/7598
30-
if (!isBuild) {
31-
expect(await page.textContent('.process-as-property')).toBe(
32-
defines.__OBJ__.process.env.SOMEVAR,
33-
)
34-
}
29+
expect(await page.textContent('.process-as-property')).toBe(
30+
defines.__OBJ__.process.env.SOMEVAR,
31+
)
3532
expect(await page.textContent('.spread-object')).toBe(
3633
JSON.stringify({ SOMEVAR: defines['process.env.SOMEVAR'] }),
3734
)

0 commit comments

Comments
 (0)