fix: set oxc.jsx.development when esbuild.jsxDev is set

sapphi-red · sapphi-red · commit 72e88c9ed98d · 2025-02-06T12:57:06.000+09:00
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts
@@ -1608,7 +1608,7 @@ export async function resolveConfig(
               typeof oxc?.jsx === 'string'
                 ? oxc.jsx
                 : {
-                    development: !isProduction,
+                    development: oxc?.jsx?.development ?? !isProduction,
                     ...oxc?.jsx,
                   },
           },
diff --git a/packages/vite/src/node/plugins/oxc.ts b/packages/vite/src/node/plugins/oxc.ts
@@ -592,8 +592,8 @@ export function convertEsbuildConfigToOxcConfig(
         break
     }
 
-    if (esbuildTransformOptions.jsxDev) {
-      jsxOptions.development = true
+    if (esbuildTransformOptions.jsxDev !== undefined) {
+      jsxOptions.development = esbuildTransformOptions.jsxDev
     }
 
     oxcOptions.jsx = jsxOptions

Original file line number	Diff line number	Diff line change
`@@ -592,8 +592,8 @@ export function convertEsbuildConfigToOxcConfig(`
`592`	`592`	`break`
`593`	`593`	`}`
`594`	`594`
`595`		`- if (esbuildTransformOptions.jsxDev) {`
`596`		`- jsxOptions.development = true`
	`595`	`+ if (esbuildTransformOptions.jsxDev !== undefined) {`
	`596`	`+ jsxOptions.development = esbuildTransformOptions.jsxDev`
`597`	`597`	`}`
`598`	`598`
`599`	`599`	`oxcOptions.jsx = jsxOptions`