wip: full bundle dev env

Author: sapphi-red

packages/vite/src/node/server/middlewares/htmlFallback.ts

@@ -1,7 +1,7 @@
 import path from 'node:path'
 import fs from 'node:fs'
 import type { Connect } from 'dep-types/connect'
-import { createDebugger } from '../../utils'
+import { createDebugger, joinUrlSegments } from '../../utils'
 import { cleanUrl } from '../../../shared/utils'
 import type { DevEnvironment } from '../environment'
 import { FullBundleDevEnvironment } from '../environments/fullBundleEnvironment'
@@ -20,8 +20,9 @@ export function htmlFallbackMiddleware(
 
   function checkFileExists(relativePath: string) {
     return (
-      memoryFiles?.has(relativePath) ??
-      fs.existsSync(path.join(root, relativePath))
+      memoryFiles?.has(
+        relativePath.slice(1), // remove first /
+      ) ?? fs.existsSync(path.join(root, relativePath))
     )
   }
 
@@ -57,7 +58,7 @@ export function htmlFallbackMiddleware(
     }
     // trailing slash should check for fallback index.html
     else if (pathname.endsWith('/')) {
-      if (checkFileExists(path.join(pathname, 'index.html'))) {
+      if (checkFileExists(joinUrlSegments(pathname, 'index.html'))) {
         const newUrl = url + 'index.html'
         debug?.(`Rewriting ${req.method} ${req.url} to ${newUrl}`)
         req.url = newUrl

packages/vite/src/node/server/middlewares/indexHtml.ts

@@ -457,8 +457,10 @@ export function indexHtmlMiddleware(
     // htmlFallbackMiddleware appends '.html' to URLs
     if (url?.endsWith('.html') && req.headers['sec-fetch-dest'] !== 'script') {
       if (fullBundleEnv) {
-        const cleanedUrl = cleanUrl(url).slice(1) // remove first /
-        let content = fullBundleEnv.memoryFiles.get(cleanedUrl)
+        const pathname = decodeURIComponent(url)
+        const filePath = pathname.slice(1) // remove first /
+
+        let content = fullBundleEnv.memoryFiles.get(filePath)
         if (!content && fullBundleEnv.memoryFiles.size !== 0) {
           return next()
         }

packages/vite/src/node/server/middlewares/memoryFiles.ts

@@ -17,13 +17,17 @@ export function memoryFilesMiddleware(
   const headers = server.config.server.headers
 
   return function viteMemoryFilesMiddleware(req, res, next) {
-    const cleanedUrl = cleanUrl(req.url!).slice(1) // remove first /
+    const cleanedUrl = cleanUrl(req.url!)
     if (cleanedUrl.endsWith('.html')) {
       return next()
     }
-    const file = memoryFiles.get(cleanedUrl)
+
+    const pathname = decodeURIComponent(cleanedUrl)
+    const filePath = pathname.slice(1) // remove first /
+
+    const file = memoryFiles.get(filePath)
     if (file) {
-      const mime = mrmime.lookup(cleanedUrl)
+      const mime = mrmime.lookup(filePath)
       if (mime) {
         res.setHeader('Content-Type', mime)
       }