Skip to content

Commit 94d4a72

Browse files
committed
fix: optimizeDeps test pass on windows
1 parent 3139c24 commit 94d4a72

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

packages/vite/src/node/optimizer/rolldownDepPlugin.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { browserExternalId, optionalPeerDepId } from '../plugins/resolve'
1414
import { isCSSRequest, isModuleCSSRequest } from '../plugins/css'
1515
import type { Environment } from '../environment'
1616
import { createBackCompatIdResolver } from '../idResolver'
17+
import { isWindows } from '../../shared/utils'
1718

1819
const externalWithConversionNamespace =
1920
'vite:dep-pre-bundle:external-conversion'
@@ -170,7 +171,8 @@ export function rolldownDepPlugin(
170171
// or package name (e.g. import "some-package.pdf")
171172
if (JS_TYPES_RE.test(resolved)) {
172173
return {
173-
id: resolved,
174+
// normalize to \\ on windows for esbuild/rolldown behavior difference: https://github.com/sapphi-red-repros/rolldown-esbuild-path-normalization
175+
id: isWindows ? resolved.replaceAll('/', '\\') : resolved,
174176
external: false,
175177
}
176178
}

0 commit comments

Comments
 (0)