fix: applyToEnvironment after configResolved (vitejs#20170)

Author: patak-dev

docs/guide/api-environment-plugins.md

@@ -184,6 +184,8 @@ export default defineConfig({
 })
 ```
 
+The `applyToEnvironment` hook is called at config time, currently after `configResolved` due to projects in the ecosystem modifying the plugins in it. Environment plugins resolution may be moved before `configResolved` in the future.
+
 ## Environment in Build Hooks
 
 In the same way as during dev, plugin hooks also receive the environment instance during build, replacing the `ssr` boolean.

packages/vite/src/node/config.ts

@@ -1433,6 +1433,16 @@ export async function resolveConfig(
       workerPostPlugins,
     )
 
+    // run configResolved hooks
+    await Promise.all(
+      createPluginHookUtils(workerResolved.plugins)
+        .getSortedPluginHooks('configResolved')
+        .map((hook) => hook.call(resolvedConfigContext, workerResolved)),
+    )
+
+    // Resolve environment plugins after configResolved because there are
+    // downstream projects modifying the plugins in it. This may change
+    // once the ecosystem is ready.
     // During Build the client environment is used to bundle the worker
     // Avoid overriding the mainConfig (resolved.environments.client)
     ;(workerResolved.environments as Record<
@@ -1448,13 +1458,6 @@ export async function resolveConfig(
       },
     }
 
-    // run configResolved hooks
-    await Promise.all(
-      createPluginHookUtils(workerResolved.plugins)
-        .getSortedPluginHooks('configResolved')
-        .map((hook) => hook.call(resolvedConfigContext, workerResolved)),
-    )
-
     return workerResolved
   }
 
@@ -1605,19 +1608,22 @@ export async function resolveConfig(
   // TODO: Deprecate config.getSortedPlugins and config.getSortedPluginHooks
   Object.assign(resolved, createPluginHookUtils(resolved.plugins))
 
-  for (const name of Object.keys(resolved.environments)) {
-    resolved.environments[name].plugins = await resolveEnvironmentPlugins(
-      new PartialEnvironment(name, resolved),
-    )
-  }
-
   // call configResolved hooks
   await Promise.all(
     resolved
       .getSortedPluginHooks('configResolved')
       .map((hook) => hook.call(resolvedConfigContext, resolved)),
   )
 
+  // Resolve environment plugins after configResolved because there are
+  // downstream projects modifying the plugins in it. This may change
+  // once the ecosystem is ready.
+  for (const name of Object.keys(resolved.environments)) {
+    resolved.environments[name].plugins = await resolveEnvironmentPlugins(
+      new PartialEnvironment(name, resolved),
+    )
+  }
+
   optimizeDepsDisabledBackwardCompatibility(resolved, resolved.optimizeDeps)
   optimizeDepsDisabledBackwardCompatibility(
     resolved,