chore: use parseAst from rolldown directly

Author: sapphi-red

packages/vite/src/node/index.ts

@@ -1,7 +1,7 @@
 import type * as Rollup from 'rolldown'
 
 export type { Rollup }
-export { parseAst, parseAstAsync } from './parseAst'
+export { parseAst, parseAstAsync } from 'rolldown/parseAst'
 export {
   defineConfig,
   loadConfigFromFile,

packages/vite/src/node/parseAst.ts

@@ -2,7 +2,7 @@ import path from 'node:path'
 import MagicString from 'magic-string'
 import { stripLiteral } from 'strip-literal'
 import type { RolldownPlugin } from 'rolldown'
-import { parseAst } from '../parseAst'
+import { parseAst } from 'rolldown/parseAst'
 import type { ResolvedConfig } from '../config'
 import {
   injectQuery,

packages/vite/src/node/plugins/assetImportMetaUrl.ts

@@ -3,7 +3,7 @@ import MagicString from 'magic-string'
 import { init, parse as parseImports } from 'es-module-lexer'
 import type { ImportSpecifier } from 'es-module-lexer'
 import { dynamicImportToGlob } from '@rollup/plugin-dynamic-import-vars'
-import { parseAst } from '../parseAst'
+import { parseAst } from 'rolldown/parseAst'
 import type { Plugin } from '../plugin'
 import type { ResolvedConfig } from '../config'
 import { CLIENT_ENTRY } from '../constants'

packages/vite/src/node/plugins/dynamicImportVars.ts

@@ -13,8 +13,8 @@ import type { StaticImport } from 'mlly'
 import { ESM_STATIC_IMPORT_RE, parseStaticImport } from 'mlly'
 import { makeLegalIdentifier } from '@rollup/pluginutils'
 import type { PartialResolvedId, RollupError } from 'rolldown'
-import type { Identifier, Literal } from 'estree'
-import { parseAst } from '../parseAst'
+import type { Identifier, Literal, Program } from 'estree'
+import { parseAst } from 'rolldown/parseAst'
 import {
   CLIENT_DIR,
   CLIENT_PUBLIC_PATH,
@@ -987,7 +987,7 @@ export function transformCjsImport(
   importer: string,
   config: ResolvedConfig,
 ): string | undefined {
-  const node = parseAst(importExp).body[0]
+  const node = (parseAst(importExp) as Program).body[0]
 
   // `export * from '...'` may cause unexpected problem, so give it a warning
   if (

packages/vite/src/node/plugins/importAnalysis.ts

@@ -16,7 +16,7 @@ import MagicString from 'magic-string'
 import { stringifyQuery } from 'ufo'
 import type { GeneralImportGlobOptions } from 'types/importGlob'
 import { escapePath, glob } from 'tinyglobby'
-import { parseAstAsync } from '../parseAst'
+import { parseAstAsync } from 'rolldown/parseAst'
 import type { Plugin } from '../plugin'
 import type { EnvironmentModuleNode } from '../server/moduleGraph'
 import type { ResolvedConfig } from '../config'

packages/vite/src/node/plugins/importMetaGlob.ts

@@ -4,12 +4,12 @@ import type { RolldownPlugin, RollupError } from 'rolldown'
 import type { RollupAstNode } from 'rollup'
 import { stripLiteral } from 'strip-literal'
 import type { Expression, ExpressionStatement } from 'estree'
+import { parseAstAsync } from 'rolldown/parseAst'
 import type { ResolvedConfig } from '../config'
 import { evalValue, injectQuery, transformStableResult } from '../utils'
 import { createBackCompatIdResolver } from '../idResolver'
 import type { ResolveIdFn } from '../idResolver'
 import { cleanUrl, slash } from '../../shared/utils'
-import { parseAstAsync } from '../parseAst'
 import type { WorkerType } from './worker'
 import { WORKER_FILE_ID, workerFileToUrl } from './worker'
 import { fileToUrl } from './asset'

packages/vite/src/node/plugins/workerImportMetaUrl.ts

@@ -62,7 +62,8 @@ import { TraceMap, originalPositionFor } from '@jridgewell/trace-mapping'
 import MagicString from 'magic-string'
 import type { FSWatcher } from 'dep-types/chokidar'
 import colors from 'picocolors'
-import { parseAst as rolldownParseAst } from '../parseAst'
+import { parseAst as rolldownParseAst } from 'rolldown/parseAst'
+import type { Program } from '@oxc-project/types'
 import type { Plugin } from '../plugin'
 import {
   combineSourcemaps,
@@ -121,10 +122,6 @@ export function throwClosedServerError(): never {
   throw err
 }
 
-// NOTE: add a env var to use parseAst from rollup for now
-const useLegacyParseAst = !!process.env.VITE_USE_LEGACY_PARSE_AST
-let legacyParseAst: typeof import('rollup/parseAst').parseAst
-
 export interface PluginContainerOptions {
   cwd?: string
   output?: OutputOptions
@@ -149,9 +146,6 @@ export async function createEnvironmentPluginContainer(
     watcher,
     autoStart,
   )
-  if (useLegacyParseAst) {
-    legacyParseAst = await import('rollup/parseAst').then((mod) => mod.parseAst)
-  }
   await container.resolveRollupOptions()
   return container
 }
@@ -625,10 +619,7 @@ class PluginContext
     super(_container.minimalContext.meta, _container.environment)
   }
 
-  parse(code: string, opts: any) {
-    if (useLegacyParseAst) {
-      return legacyParseAst(code, opts)
-    }
+  parse(code: string, opts: any): Program {
     return rolldownParseAst(code, opts)
   }
 

packages/vite/src/node/server/pluginContainer.ts

@@ -18,7 +18,7 @@ import type {
 import { extract_names as extractNames } from 'periscopic'
 import { walk as eswalk } from 'estree-walker'
 import type { RawSourceMap } from '@ampproject/remapping'
-import { parseAstAsync as rolldownParseAstAsync } from '../parseAst'
+import { parseAstAsync as rolldownParseAstAsync } from 'rolldown/parseAst'
 import type { TransformResult } from '../server/transformRequest'
 import {
   combineSourcemaps,