Skip to content

Commit b49c080

Browse files
committed
chore: don't show optimizeDeps.esbuildOptions deprecation warning if not used
1 parent 7a7f61c commit b49c080

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

packages/vite/src/node/config.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1010,7 +1010,10 @@ function resolveDepOptimizationOptions(
10101010
consumer: 'client' | 'server' | undefined,
10111011
logger: Logger,
10121012
): DepOptimizationOptions {
1013-
if (optimizeDeps?.esbuildOptions) {
1013+
if (
1014+
optimizeDeps?.esbuildOptions &&
1015+
Object.keys(optimizeDeps.esbuildOptions).length > 0
1016+
) {
10141017
logger.warn(
10151018
colors.yellow(
10161019
`You have set \`optimizeDeps.esbuildOptions\` but this options is now deprecated. ` +

packages/vite/src/node/optimizer/scan.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -257,14 +257,6 @@ async function prepareRolldownScanner(
257257
): Promise<{ build: () => Promise<void> } | undefined> {
258258
if (scanContext.cancelled) return
259259

260-
if (environment.config.optimizeDeps.esbuildOptions) {
261-
environment.logger.error(
262-
`You've set "optimizeDeps.esbuildOptions" in your config. ` +
263-
`This is deprecated and vite already use rollup to optimize packages. ` +
264-
`Please use "optimizeDeps.rollupOptions" instead.`,
265-
)
266-
}
267-
268260
const { plugins: pluginsFromConfig = [], ...rollupOptions } =
269261
environment.config.optimizeDeps.rollupOptions ?? {}
270262

0 commit comments

Comments
 (0)