feat(types): allow rollup plugin to be assigned to plugins option (#176)

Author: sapphi-red

packages/vite/src/node/__tests_dts__/plugin.ts

@@ -1,9 +1,10 @@
 /**
  * This is a development only file for testing types.
  */
-import type { Plugin as RollupPlugin } from 'rolldown'
+import type { Plugin as RolldownPlugin } from 'rolldown'
 import type { Equal, ExpectExtends, ExpectTrue } from '@type-challenges/utils'
-import type { Plugin, PluginContextExtension } from '../plugin'
+import type { Plugin as RollupPlugin } from 'rollup'
+import type { Plugin, PluginContextExtension, PluginOption } from '../plugin'
 import type { ROLLUP_HOOKS } from '../constants'
 import type {
   GetHookContextMap,
@@ -26,13 +27,18 @@ type HooksMissingInConstants = Exclude<
 
 export type cases = [
   // Ensure environment plugin hooks are superset of rollup plugin hooks
-  ExpectTrue<ExpectExtends<RollupPlugin, Plugin>>,
+  ExpectTrue<ExpectExtends<RolldownPlugin, Plugin>>,
 
   // Ensure all Rollup hooks have Vite's plugin context extension
   ExpectTrue<Equal<HooksMissingExtension, never>>,
 
   // Ensure the `ROLLUP_HOOKS` constant is up-to-date
   ExpectTrue<Equal<HooksMissingInConstants, never>>,
+
+  // Ensure all Vite plugins, Rolldown plugins, and Rollup plugins can be assigned to `plugins` option
+  ExpectTrue<ExpectExtends<PluginOption, RolldownPlugin>>,
+  ExpectTrue<ExpectExtends<PluginOption, RollupPlugin>>,
+  ExpectTrue<ExpectExtends<PluginOption, Plugin>>,
 ]
 
 export {}

packages/vite/src/node/plugin.ts

@@ -344,7 +344,12 @@ type Thenable<T> = T | Promise<T>
 
 export type FalsyPlugin = false | null | undefined
 
-export type PluginOption = Thenable<Plugin | FalsyPlugin | PluginOption[]>
+export type PluginOption = Thenable<
+  | Plugin
+  | { name: string } // for rollup plugin compatibility
+  | FalsyPlugin
+  | PluginOption[]
+>
 
 export async function resolveEnvironmentPlugins(
   environment: PartialEnvironment,