Skip to content

Commit de8164a

Browse files
authored
test: reduce diff with normal Vite (#161)
1 parent 9615b13 commit de8164a

File tree

6 files changed

+8
-7
lines changed

6 files changed

+8
-7
lines changed

playground/assets/vite.config-encoded-base.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export default defineConfig({
1515
build: {
1616
...baseConfig.build,
1717
outDir: 'dist/encoded-base',
18-
// watch: null,
18+
watch: null,
1919
minify: false,
2020
assetsInlineLimit: 0,
2121
rollupOptions: {

playground/assets/vite.config-relative-base.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export default defineConfig(({ isPreview }) => ({
77
build: {
88
...baseConfig.build,
99
outDir: 'dist/relative-base',
10-
// watch: null,
10+
watch: null,
1111
minify: false,
1212
assetsInlineLimit: 0,
1313
rollupOptions: {

playground/assets/vite.config-runtime-base.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default defineConfig({
1212
build: {
1313
...baseConfig.build,
1414
outDir: 'dist/runtime-base',
15-
// watch: null,
15+
watch: null,
1616
minify: false,
1717
assetsInlineLimit: 0,
1818
rollupOptions: {

playground/assets/vite.config-url-base.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export default defineConfig({
1414
build: {
1515
...baseConfig.build,
1616
outDir: 'dist/url-base',
17-
// watch: null,
17+
watch: null,
1818
minify: false,
1919
assetsInlineLimit: 0,
2020
rollupOptions: {

playground/optimize-deps/__tests__/optimize-deps.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ test('default import from webpacked cjs (clipboard)', async () => {
3030
await expectWithRetry(() => page.textContent('.cjs-clipboard')).toBe('ok')
3131
})
3232

33-
test('dynamic imports from cjs dep (react)', async () => {
33+
// NOTE: rolldown behaves differently from @rollup/plugin-commonjs https://github.com/rolldown/rolldown/issues/2031
34+
test.skip('dynamic imports from cjs dep (react)', async () => {
3435
await expectWithRetry(() => page.textContent('.cjs-dynamic button')).toBe(
3536
'count is 0',
3637
)
@@ -52,7 +53,8 @@ test('dynamic default import from webpacked cjs (clipboard)', async () => {
5253
)
5354
})
5455

55-
test('dynamic default import from cjs (cjs-dynamic-dep-cjs-compiled-from-esm)', async () => {
56+
// NOTE: rolldown behaves differently from @rollup/plugin-commonjs https://github.com/rolldown/rolldown/issues/2031
57+
test.skip('dynamic default import from cjs (cjs-dynamic-dep-cjs-compiled-from-esm)', async () => {
5658
await expectWithRetry(() =>
5759
page.textContent('.cjs-dynamic-dep-cjs-compiled-from-esm'),
5860
).toBe('ok')

vitest.config.e2e.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export default defineConfig({
1818
...(isBuild
1919
? [
2020
'./playground/object-hooks/**/*.spec.[tj]s', // object hook sequential
21-
'./playground/optimize-deps/**/*.spec.[tj]s', // https://github.com/rolldown/rolldown/issues/2031
2221
]
2322
: []),
2423
...defaultExclude,

0 commit comments

Comments
 (0)