Skip to content

Commit 8f896ff

Browse files
authored
feat(plugin-react): make tests pass with plugin-react-oxc (#377)
1 parent 0aee710 commit 8f896ff

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

tests/vite-plugin-react.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,8 @@ export async function test(options: RunOptions) {
88
build: 'build',
99
beforeTest: 'pnpm playwright install chromium',
1010
test: ['test', 'typecheck'],
11+
overrides: {
12+
'@vitejs/plugin-react-oxc>vite': 'catalog:rolldown-vite',
13+
},
1114
})
1215
}

utils.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,12 +522,18 @@ export async function applyPackageOverrides(
522522
await overridePackageManagerVersion(pkg, pm)
523523

524524
if (pm === 'pnpm') {
525+
const overridesWithoutSpecialSyntax = Object.fromEntries(
526+
Object.entries(overrides)
527+
//eslint-disable-next-line @typescript-eslint/no-unused-vars
528+
.filter(([key, value]) => (value as string).includes('>')),
529+
)
530+
525531
if (!pkg.devDependencies) {
526532
pkg.devDependencies = {}
527533
}
528534
pkg.devDependencies = {
529535
...pkg.devDependencies,
530-
...overrides, // overrides must be present in devDependencies or dependencies otherwise they may not work
536+
...overridesWithoutSpecialSyntax, // overrides must be present in devDependencies or dependencies otherwise they may not work
531537
}
532538
if (!pkg.pnpm) {
533539
pkg.pnpm = {}

0 commit comments

Comments
 (0)