feat: show expected failures for rolldown-vite runs (#395)

Author: sapphi-red

.github/workflows/ecosystem-ci-rolldown.yml

@@ -107,3 +107,4 @@ jobs:
           STATUS: ${{ job.status }}
           DISCORD_WEBHOOK_URL: ${{ secrets.DISCORD_WEBHOOK_URL_ROLLDOWN_VITE }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          IS_ROLLDOWN_VITE: "1"

discord-webhook.ts

@@ -11,13 +11,18 @@ type Env = {
 	SUITE?: string
 	STATUS?: Status
 	DISCORD_WEBHOOK_URL?: string
+	IS_ROLLDOWN_VITE?: '1'
 }
 
 const statusConfig = {
 	success: {
 		color: parseInt('57ab5a', 16),
 		emoji: ':white_check_mark:',
 	},
+	expectedFailure: {
+		color: parseInt('c69026', 16),
+		emoji: ':construction:',
+	},
 	failure: {
 		color: parseInt('e5534b', 16),
 		emoji: ':x:',
@@ -53,6 +58,14 @@ async function run() {
 	assertEnv('SUITE', env.SUITE)
 	assertEnv('STATUS', env.STATUS)
 	assertEnv('DISCORD_WEBHOOK_URL', env.DISCORD_WEBHOOK_URL)
+	const isRolldownVite = !!env.IS_ROLLDOWN_VITE
+	const expectedFailureReason = isRolldownVite
+		? await loadExpectedFailureReason(env.SUITE)
+		: undefined
+	const status =
+		env.STATUS === 'failure' && expectedFailureReason
+			? 'expectedFailure'
+			: env.STATUS
 
 	await setupEnvironment()
 
@@ -67,9 +80,13 @@ async function run() {
 		avatar_url: 'https://github.com/vitejs.png',
 		embeds: [
 			{
-				title: `${statusConfig[env.STATUS].emoji}  ${env.SUITE}`,
-				description: await createDescription(env.SUITE, targetText),
-				color: statusConfig[env.STATUS].color,
+				title: `${statusConfig[status].emoji}  ${env.SUITE}`,
+				description: await createDescription(
+					env.SUITE,
+					targetText,
+					expectedFailureReason,
+				),
+				color: statusConfig[status].color,
 			},
 		],
 	}
@@ -97,6 +114,12 @@ function assertEnv<T>(
 	}
 }
 
+async function loadExpectedFailureReason(suite: string) {
+	const module = await import(`./tests/${suite}.ts`)
+	const reason: string | undefined = module.rolldownViteExpectedFailureReason
+	return reason?.trim()
+}
+
 async function createRunUrl(suite: string) {
 	const result = await fetchJobs()
 	if (!result) {
@@ -151,13 +174,24 @@ async function fetchJobs() {
 	}
 }
 
-async function createDescription(suite: string, targetText: string) {
+async function createDescription(
+	suite: string,
+	targetText: string,
+	expectedFailureReason: string | undefined,
+) {
 	const runUrl = await createRunUrl(suite)
 	const open = runUrl === undefined ? 'Null' : `[Open](${runUrl})`
-
-	return `
+	let message = `
 :scroll:\u00a0\u00a0${open}\u3000\u3000:zap:\u00a0\u00a0${targetText}
 `.trim()
+	if (expectedFailureReason) {
+		message +=
+			'\n' +
+			`
+:bulb:\u00a0\u00a0${expectedFailureReason}
+`.trim()
+	}
+	return message
 }
 
 function createTargetText(

tests/astro.ts

@@ -10,3 +10,7 @@ export async function test(options: RunOptions) {
 		test: 'test:vite-ci',
 	})
 }
+
+export const rolldownViteExpectedFailureReason = `
+needs to be updated on astro side (manualChunks) and rolldown side (https://github.com/rolldown/rolldown/issues/3640)
+`

tests/histoire.ts

@@ -10,3 +10,7 @@ export async function test(options: RunOptions) {
 		test: ['test', 'test:examples'],
 	})
 }
+
+export const rolldownViteExpectedFailureReason = `
+needs to be updated on histoire side (manualChunks)
+`

tests/ladle.ts

@@ -11,3 +11,7 @@ export async function test(options: RunOptions) {
 		test: 'test',
 	})
 }
+
+export const rolldownViteExpectedFailureReason = `
+needs to be updated on ladle side (transformWithEsbuild)
+`

tests/nuxt.ts

@@ -13,3 +13,7 @@ export async function test(options: RunOptions) {
 		test: ['test:fixtures', 'test:fixtures:dev', 'test:types'],
 	})
 }
+
+export const rolldownViteExpectedFailureReason = `
+needs to be updated on rolldown side (different chunking behavior, also https://github.com/oxc-project/oxc/issues/9170)
+`

tests/one.ts

@@ -11,3 +11,7 @@ export async function test(options: RunOptions) {
 		test: 'test:vite-ecosystem-ci',
 	})
 }
+
+export const rolldownViteExpectedFailureReason = `
+needs to be updated on one side (manualChunks)
+`

tests/qwik.ts

@@ -10,3 +10,7 @@ export async function test(options: RunOptions) {
 		test: 'test.vite',
 	})
 }
+
+export const rolldownViteExpectedFailureReason = `
+needs to be updated on qwik side (manualChunks, types)
+`

tests/storybook.ts

@@ -11,3 +11,7 @@ export async function test(options: RunOptions) {
 		test: 'vite-ecosystem-ci:test',
 	})
 }
+
+export const rolldownViteExpectedFailureReason = `
+needs to be updated on rolldown side (https://github.com/vitejs/rolldown-vite/issues/182)
+`

tests/sveltekit.ts

@@ -18,3 +18,7 @@ export async function test(options: RunOptions) {
 		],
 	})
 }
+
+export const rolldownViteExpectedFailureReason = `
+needs to be updated on sveltekit side
+`