From 188eacef1c656238ba6c976336b8d0810a156f72 Mon Sep 17 00:00:00 2001 From: sapphi-red <49056869+sapphi-red@users.noreply.github.com> Date: Fri, 4 Apr 2025 18:13:47 +0900 Subject: [PATCH] feat(plugin-react): make tests pass with plugin-react-oxc --- tests/vite-plugin-react.ts | 3 +++ utils.ts | 8 +++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/vite-plugin-react.ts b/tests/vite-plugin-react.ts index df6cbf43..5afd6046 100755 --- a/tests/vite-plugin-react.ts +++ b/tests/vite-plugin-react.ts @@ -8,5 +8,8 @@ export async function test(options: RunOptions) { build: 'build', beforeTest: 'pnpm playwright install chromium', test: ['test', 'typecheck'], + overrides: { + '@vitejs/plugin-react-oxc>vite': 'catalog:rolldown-vite', + }, }) } diff --git a/utils.ts b/utils.ts index 29eeeb99..abf7f143 100644 --- a/utils.ts +++ b/utils.ts @@ -522,12 +522,18 @@ export async function applyPackageOverrides( await overridePackageManagerVersion(pkg, pm) if (pm === 'pnpm') { + const overridesWithoutSpecialSyntax = Object.fromEntries( + Object.entries(overrides) + //eslint-disable-next-line @typescript-eslint/no-unused-vars + .filter(([key, value]) => (value as string).includes('>')), + ) + if (!pkg.devDependencies) { pkg.devDependencies = {} } pkg.devDependencies = { ...pkg.devDependencies, - ...overrides, // overrides must be present in devDependencies or dependencies otherwise they may not work + ...overridesWithoutSpecialSyntax, // overrides must be present in devDependencies or dependencies otherwise they may not work } if (!pkg.pnpm) { pkg.pnpm = {}