fix: find up package.json when project is located at subfolder (#78)

* feat: find up package.json

* fix: pass vite project's root

* improve code style

* chore: fix pnpm resolve

* chore: no longer need dummy package.json

Co-authored-by: csr632 <[email protected]>

Author: cijiugechu

package.json

@@ -33,14 +33,15 @@
     "sirv": "^2.0.2",
     "slash": "^3.0.0",
     "typescript": "^4.7.4",
-    "vite-pages-theme-basic": "workspace:*",
-    "vite-plugin-react-pages": "workspace:*",
     "wait-on": "^6.0.1"
   },
   "pnpm": {
     "overrides": {
       "react": "^17.0.1",
-      "react-dom": "^17.0.1"
+      "react-dom": "^17.0.1",
+      "vite-plugin-react-pages": "workspace:*",
+      "vite-pages-theme-doc": "workspace:*",
+      "vite-pages-theme-basic": "workspace:*"
     },
     "peerDependencyRules": {
       "ignoreMissing": [

packages/create-project/template-lib/docs/package.json

@@ -76,6 +76,7 @@
     "jotai": "^0.15.3",
     "mini-debounce": "^1.0.8",
     "minimist": "^1.2.5",
+    "pkg-up": "^3.1.0",
     "remark-frontmatter": "^2.0.0",
     "slash": "^3.0.0",
     "tiny-invariant": "^1.1.0",

packages/react-pages/package.json

@@ -1,5 +1,7 @@
 import * as path from 'path'
 import fs from 'fs-extra'
+import pkgUp from 'pkg-up'
+import chalk from 'chalk'
 import type { Plugin, IndexHtmlTransformContext } from 'vite'
 import type { MdxPlugin } from 'vite-plugin-mdx/dist/types'
 import {
@@ -99,7 +101,7 @@ export default function pluginFactory(opts: PluginConfig = {}): Plugin {
         )
       } else {
         logger.warn(
-          '[react-pages] Please install [email protected] or higher'
+          '[vite-plugin-react-pages] Please install [email protected] or higher'
         )
       }
     },
@@ -221,17 +223,26 @@ async function getRemarkPlugins(root: string) {
     ImageMdxPlugin,
     FileTextMdxPlugin,
   ]
-  const pkgJsonPath = path.join(root, 'package.json')
-  // TODO: user may put the whole vite-pages project
-  // under a sub folder (which is the root here),
-  // so the package.json will be located at the upper folder.
-  // checkout playground/custom-find-pages2.
-  const hasPkgJson = fs.pathExistsSync(pkgJsonPath)
+
+  // pass vite project's root otherwise it will
+  // start from process.cwd() by default
+  const pkgJsonPath = pkgUp.sync({
+    cwd: root,
+  })
+
+  if (pkgJsonPath === null) {
+    console.error(
+      chalk.red(
+        `[vite-plugin-react-pages] Could not find 'package.json', does it exist?\n'`
+      )
+    )
+    process.exit(1)
+  }
 
   const pkgJson = await fs.readJSON(pkgJsonPath)
 
   // Inject frontmatter parser if missing
-  const { devDependencies = {}, dependencies = {} } = hasPkgJson ? pkgJson : {}
+  const { devDependencies = {}, dependencies = {} } = pkgJson
   // By default we add remark-frontmatter automatically.
   // But if user install their own remark-frontmatter,
   // they are responsible to add the plugin manually