Skip to content

Commit 3e3af0c

Browse files
committed
ci: avoid interpolation
1 parent fbd64c5 commit 3e3af0c

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

.github/workflows/ci-rsc.yml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,18 +65,24 @@ jobs:
6565
- name: install react
6666
if: ${{ matrix.react_version }}
6767
run: |
68-
sed -i "/^overrides:/a\ react: \"${{ matrix.react_version }}\"" pnpm-workspace.yaml
69-
sed -i "/^overrides:/a\ react-dom: \"${{ matrix.react_version }}\"" pnpm-workspace.yaml
70-
sed -i "/^overrides:/a\ react-server-dom-webpack: \"${{ matrix.react_version }}\"" pnpm-workspace.yaml
68+
sed -i "/^overrides:/a\ react: \"$REACT_VERSION\"" pnpm-workspace.yaml
69+
sed -i "/^overrides:/a\ react-dom: \"$REACT_VERSION\"" pnpm-workspace.yaml
70+
sed -i "/^overrides:/a\ react-server-dom-webpack: \"$REACT_VERSION\"" pnpm-workspace.yaml
7171
pnpm i --no-frozen-lockfile
72+
env:
73+
REACT_VERSION: ${{ matrix.react_version }}
7274
- run: pnpm build
7375
- name: install rolldown
7476
if: ${{ matrix.rolldown }}
7577
run: |
7678
sed -i '/^overrides:/a\ vite: "npm:rolldown-vite@latest"' pnpm-workspace.yaml
7779
pnpm i --no-frozen-lockfile
78-
- run: pnpm -C packages/plugin-rsc exec playwright install ${{ matrix.browser }}
79-
- run: pnpm -C packages/plugin-rsc test-e2e-ci --project=${{ matrix.browser }}
80+
- run: pnpm -C packages/plugin-rsc exec playwright install "$BROWSER_NAME"
81+
env:
82+
BROWSER_NAME: ${{ matrix.browser }}
83+
- run: pnpm -C packages/plugin-rsc test-e2e-ci --project="$BROWSER_NAME"
84+
env:
85+
BROWSER_NAME: ${{ matrix.browser }}
8086
- uses: actions/upload-artifact@v4
8187
if: always()
8288
with:

0 commit comments

Comments
 (0)