Skip to content

Commit 4cafd9a

Browse files
authored
chore(rsc): remove loader from react-router example for react 19.2 (#910)
1 parent 45e93fb commit 4cafd9a

File tree

4 files changed

+6
-25
lines changed

4 files changed

+6
-25
lines changed

packages/plugin-rsc/e2e/react-router.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ test.describe('build-cloudflare', () => {
3939
})
4040

4141
function defineTest(f: Fixture) {
42-
test('loader', async ({ page }) => {
43-
await page.goto(f.url())
44-
await expect(page.getByText(`loaderData: {"name":"Unknown"}`)).toBeVisible()
45-
})
46-
4742
test('client', async ({ page }) => {
4843
await page.goto(f.url('./about'))
4944
await waitForHydration(page)

packages/plugin-rsc/examples/react-router/app/root.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { TestClientState, TestHydrated } from './routes/client'
44
import { DumpError, GlobalNavigationLoadingBar } from './routes/root.client'
55

66
export function Layout({ children }: { children: React.ReactNode }) {
7-
console.log('Layout')
7+
console.log('[debug] root - Layout')
88
return (
99
<html lang="en">
1010
<head>
@@ -41,7 +41,7 @@ export function Layout({ children }: { children: React.ReactNode }) {
4141
}
4242

4343
export default function Component() {
44-
console.log('Root')
44+
console.log('[debug] root - Component')
4545
return (
4646
<>
4747
<Outlet />

packages/plugin-rsc/examples/react-router/app/routes/home.actions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
export async function sayHello(defaultName: string, formData: FormData) {
44
await new Promise((resolve) => setTimeout(resolve, 500))
55
const name = formData.get('name') || defaultName
6-
console.log(`Hello, ${name}`)
6+
console.log(`[debug] sayHello - ${name}`)
77
}

packages/plugin-rsc/examples/react-router/app/routes/home.tsx

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,19 @@
1-
namespace Route {
2-
export type LoaderArgs = any
3-
export type ComponentProps = any
4-
}
5-
61
import { sayHello } from './home.actions.ts'
72
import { PendingButton } from './home.client.tsx'
83
import './home.css'
94
import { TestActionStateServer } from './test-action-state/server.tsx'
105

11-
export function loader({ request }: Route.LoaderArgs) {
12-
const url = new URL(request.url)
13-
const name = url.searchParams.get('name')
14-
return { name: name || 'Unknown' }
15-
}
16-
17-
const Component = ({ loaderData }: Route.ComponentProps) => {
6+
const Component = () => {
187
return (
198
<main className="container my-8 px-8 mx-auto">
209
<article className="paper prose max-w-none">
2110
<h1>Home</h1>
2211
<p>This is the home page.</p>
2312
<span className="test-style-home">[test-style-home]</span>
24-
<pre>
25-
<code>loaderData: {JSON.stringify(loaderData)}</code>
26-
</pre>
2713
<h2>Server Action</h2>
2814
<form
2915
className="no-prose grid gap-6"
30-
action={sayHello.bind(null, loaderData.name)}
16+
action={sayHello.bind(null, 'Demo')}
3117
>
3218
<div className="grid gap-1">
3319
<label className="label" htmlFor="name">
@@ -38,7 +24,7 @@ const Component = ({ loaderData }: Route.ComponentProps) => {
3824
id="name"
3925
type="text"
4026
name="name"
41-
placeholder={loaderData.name}
27+
placeholder={'Demo'}
4228
/>
4329
</div>
4430
<div>

0 commit comments

Comments
 (0)