Skip to content

Commit 607abb7

Browse files
Copilothi-ogawa
andcommitted
refactor(rsc): simplify by reassigning request after parseRenderRequest
Co-authored-by: hi-ogawa <[email protected]>
1 parent 951c9c2 commit 607abb7

File tree

3 files changed

+15
-12
lines changed

3 files changed

+15
-12
lines changed

packages/plugin-rsc/examples/basic/src/framework/entry.rsc.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ async function handleRequest({
3535
}): Promise<Response> {
3636
// differentiate RSC, SSR, action, etc.
3737
const renderRequest = parseRenderRequest(request)
38+
request = renderRequest.request
3839

3940
// handle server function request
4041
let returnValue: RscPayload['returnValue'] | undefined
@@ -44,10 +45,10 @@ async function handleRequest({
4445
if (renderRequest.isAction === true) {
4546
if (renderRequest.actionId) {
4647
// action is called via `ReactClient.setServerCallback`.
47-
const contentType = renderRequest.request.headers.get('content-type')
48+
const contentType = request.headers.get('content-type')
4849
const body = contentType?.startsWith('multipart/form-data')
49-
? await renderRequest.request.formData()
50-
: await renderRequest.request.text()
50+
? await request.formData()
51+
: await request.text()
5152
temporaryReferences = createTemporaryReferenceSet()
5253
const args = await decodeReply(body, { temporaryReferences })
5354
const action = await loadServerAction(renderRequest.actionId)
@@ -62,7 +63,7 @@ async function handleRequest({
6263
// otherwise server function is called via `<form action={...}>`
6364
// before hydration (e.g. when javascript is disabled).
6465
// aka progressive enhancement.
65-
const formData = await renderRequest.request.formData()
66+
const formData = await request.formData()
6667
const decodedAction = await decodeAction(formData)
6768
try {
6869
const result = await decodedAction()

packages/plugin-rsc/examples/starter-cf-single/src/framework/entry.rsc.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export type RscPayload = {
1919
async function handler(request: Request): Promise<Response> {
2020
// differentiate RSC, SSR, action, etc.
2121
const renderRequest = parseRenderRequest(request)
22+
request = renderRequest.request
2223

2324
// handle server function request
2425
let returnValue: RscPayload['returnValue'] | undefined
@@ -28,10 +29,10 @@ async function handler(request: Request): Promise<Response> {
2829
if (renderRequest.isAction === true) {
2930
if (renderRequest.actionId) {
3031
// action is called via `ReactClient.setServerCallback`.
31-
const contentType = renderRequest.request.headers.get('content-type')
32+
const contentType = request.headers.get('content-type')
3233
const body = contentType?.startsWith('multipart/form-data')
33-
? await renderRequest.request.formData()
34-
: await renderRequest.request.text()
34+
? await request.formData()
35+
: await request.text()
3536
temporaryReferences = createTemporaryReferenceSet()
3637
const args = await decodeReply(body, { temporaryReferences })
3738
const action = await loadServerAction(renderRequest.actionId)
@@ -46,7 +47,7 @@ async function handler(request: Request): Promise<Response> {
4647
// otherwise server function is called via `<form action={...}>`
4748
// before hydration (e.g. when javascript is disabled).
4849
// aka progressive enhancement.
49-
const formData = await renderRequest.request.formData()
50+
const formData = await request.formData()
5051
const decodedAction = await decodeAction(formData)
5152
try {
5253
const result = await decodedAction()

packages/plugin-rsc/examples/starter/src/framework/entry.rsc.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ export type RscPayload = {
2828
export default async function handler(request: Request): Promise<Response> {
2929
// differentiate RSC, SSR, action, etc.
3030
const renderRequest = parseRenderRequest(request)
31+
request = renderRequest.request
3132

3233
// handle server function request
3334
let returnValue: RscPayload['returnValue'] | undefined
@@ -37,10 +38,10 @@ export default async function handler(request: Request): Promise<Response> {
3738
if (renderRequest.isAction === true) {
3839
if (renderRequest.actionId) {
3940
// action is called via `ReactClient.setServerCallback`.
40-
const contentType = renderRequest.request.headers.get('content-type')
41+
const contentType = request.headers.get('content-type')
4142
const body = contentType?.startsWith('multipart/form-data')
42-
? await renderRequest.request.formData()
43-
: await renderRequest.request.text()
43+
? await request.formData()
44+
: await request.text()
4445
temporaryReferences = createTemporaryReferenceSet()
4546
const args = await decodeReply(body, { temporaryReferences })
4647
const action = await loadServerAction(renderRequest.actionId)
@@ -55,7 +56,7 @@ export default async function handler(request: Request): Promise<Response> {
5556
// otherwise server function is called via `<form action={...}>`
5657
// before hydration (e.g. when javascript is disabled).
5758
// aka progressive enhancement.
58-
const formData = await renderRequest.request.formData()
59+
const formData = await request.formData()
5960
const decodedAction = await decodeAction(formData)
6061
try {
6162
const result = await decodedAction()

0 commit comments

Comments
 (0)