Skip to content

Commit a15ad1b

Browse files
committed
test: simplify ts-lib test
1 parent c8ecad0 commit a15ad1b

File tree

11 files changed

+49
-85
lines changed

11 files changed

+49
-85
lines changed
Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,22 @@
1-
import { expect, test } from '@playwright/test'
1+
import { expect, test, type Page } from '@playwright/test'
22
import { setupBuildAndPreview, setupDevServer } from '../../utils.ts'
33

44
test('TS lib build', async ({ page }) => {
55
const { testUrl, server } = await setupBuildAndPreview('ts-lib')
66
await page.goto(testUrl)
7-
await expect(page.locator('main')).toHaveText('Home page')
8-
9-
await page.locator('a', { hasText: 'About' }).click()
10-
await expect(page.locator('main')).toHaveText('About page')
11-
7+
await testNonJs(page)
128
await server.httpServer.close()
139
})
1410

1511
test('TS lib dev', async ({ page }) => {
1612
const { testUrl, server } = await setupDevServer('ts-lib')
1713
await page.goto(testUrl)
18-
await expect(page.locator('main')).toHaveText('Home page')
19-
20-
await page.locator('a', { hasText: 'About' }).click()
21-
await expect(page.locator('main')).toHaveText('About page')
22-
14+
await testNonJs(page)
2315
await server.close()
2416
})
17+
18+
async function testNonJs(page: Page) {
19+
await expect(page.getByTestId('test-non-js')).toHaveText('test-non-js: 0')
20+
await page.getByTestId('test-non-js').click()
21+
await expect(page.getByTestId('test-non-js')).toHaveText('test-non-js: 1')
22+
}

packages/plugin-react-swc/playground/ts-lib/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
"preview": "vite preview"
99
},
1010
"dependencies": {
11-
"@generouted/react-router": "^1.20.0",
12-
"generouted": "1.11.7",
11+
"@vitejs/test-dep-non-js": "file:./test-dep/non-js",
1312
"react": "^19.1.0",
1413
"react-dom": "^19.1.0",
1514
"react-router-dom": "^7.6.3"

packages/plugin-react-swc/playground/ts-lib/src/pages/_app.tsx renamed to packages/plugin-react-swc/playground/ts-lib/src/app.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
import { Link, Outlet } from 'react-router-dom'
1+
import TestNonJs from '@vitejs/test-dep-non-js'
22

33
export default function App() {
44
return (
55
<section style={{ margin: 24 }}>
66
<header style={{ display: 'flex', gap: 24 }}>
7-
<Link to="/">Home</Link>
8-
<Link to="/about">About</Link>
7+
{/* <Link to="/">Home</Link>
8+
<Link to="/about">About</Link> */}
99
</header>
1010

1111
<main>
12-
<Outlet />
12+
<TestNonJs />
1313
</main>
1414
</section>
1515
)
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { StrictMode } from 'react'
22
import { createRoot } from 'react-dom/client'
3-
import { Routes } from 'generouted/react-router'
3+
import App from './app'
44

55
createRoot(document.getElementById('root')!).render(
66
<StrictMode>
7-
<Routes />
7+
<App />
88
</StrictMode>,
99
)

packages/plugin-react-swc/playground/ts-lib/src/pages/404.tsx

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/plugin-react-swc/playground/ts-lib/src/pages/about.tsx

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/plugin-react-swc/playground/ts-lib/src/pages/index.tsx

Lines changed: 0 additions & 10 deletions
This file was deleted.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import React from 'react'
2+
3+
export default function TestNonJs() {
4+
const [count, setCount] = React.useState(0)
5+
return (
6+
<button data-testid="test-non-js" onClick={() => setCount(count + 1)}>
7+
test-non-js: {count}
8+
</button>
9+
)
10+
}
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"name": "@vitejs/test-dep-non-js",
3+
"private": true,
4+
"type": "module",
5+
"exports": "./index.tsx",
6+
"peerDependencies": {
7+
"react": "*"
8+
}
9+
}

packages/plugin-react-swc/playground/ts-lib/vite.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,5 @@ import { defineConfig } from 'vite'
22
import react from '@vitejs/plugin-react-swc'
33

44
export default defineConfig({
5-
optimizeDeps: { include: ['react-router-dom'] },
65
plugins: [react()],
76
})

0 commit comments

Comments
 (0)