fix(react): respect tsconfig jsxImportSource by default

Author: hi-ogawa

packages/plugin-react/src/index.ts

@@ -153,7 +153,7 @@ export default function viteReact(opts: Options = {}): Plugin[] {
             oxc: {
               jsx: {
                 runtime: 'automatic',
-                importSource: jsxImportSource,
+                importSource: opts.jsxImportSource,
                 refresh: command === 'serve',
               },
               jsxRefreshInclude: include,
@@ -174,7 +174,8 @@ export default function viteReact(opts: Options = {}): Plugin[] {
         return {
           esbuild: {
             jsx: 'automatic',
-            jsxImportSource: jsxImportSource,
+            // keep undefined by default so that vite's esbuild transform can prioritize jsxImportSource from tsconfig
+            jsxImportSource: opts.jsxImportSource,
           },
           optimizeDeps: { esbuildOptions: { jsx: 'automatic' } },
         }

playground/tsconfig/__tests__/tsconfig.spec.ts

@@ -0,0 +1,10 @@
+import { expect, test } from 'vitest'
+import { page } from '~utils'
+
+test('respect tsconfig jsxImportSource', async () => {
+  await expect
+    .poll(() =>
+      page.getByTestId('emotion').evaluate((el) => getComputedStyle(el).color),
+    )
+    .toBe('rgb(255, 0, 0)')
+})

playground/tsconfig/index.html

@@ -0,0 +1,2 @@
+<div id="app"></div>
+<script type="module" src="./src/main.tsx"></script>

playground/tsconfig/package.json

@@ -0,0 +1,21 @@
+{
+  "name": "@vitejs/test-react-tsconfig",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "dev": "vite",
+    "build": "vite build",
+    "debug": "node --inspect-brk vite",
+    "preview": "vite preview"
+  },
+  "dependencies": {
+    "@emotion/react": "^11.14.0",
+    "react": "^19.1.1",
+    "react-dom": "^19.1.1"
+  },
+  "devDependencies": {
+    "@types/react": "^19.1.9",
+    "@types/react-dom": "^19.1.7",
+    "@vitejs/plugin-react": "workspace:*"
+  }
+}

playground/tsconfig/src/App.tsx

@@ -0,0 +1,7 @@
+export default function App() {
+  return (
+    <div data-testid="emotion" css={{ color: 'rgb(255, 0, 0)' }}>
+      This should be red
+    </div>
+  )
+}

playground/tsconfig/src/main.tsx

@@ -0,0 +1,4 @@
+import ReactDOM from 'react-dom/client'
+import App from './App.jsx'
+
+ReactDOM.createRoot(document.getElementById('app')!).render(<App />)

playground/tsconfig/tsconfig.json

@@ -0,0 +1,26 @@
+{
+  "include": ["src"],
+  "compilerOptions": {
+    "target": "ES2020",
+    "useDefineForClassFields": true,
+    "lib": ["ES2020", "DOM", "DOM.Iterable"],
+    "types": ["vite/client"],
+    "module": "ESNext",
+    "skipLibCheck": true,
+
+    /* Bundler mode */
+    "moduleResolution": "bundler",
+    "allowImportingTsExtensions": true,
+    "resolveJsonModule": true,
+    "isolatedModules": true,
+    "noEmit": true,
+    "jsx": "react-jsx",
+    "jsxImportSource": "@emotion/react",
+
+    /* Linting */
+    "strict": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noFallthroughCasesInSwitch": true
+  }
+}

playground/tsconfig/vite.config.ts

@@ -0,0 +1,6 @@
+import react from '@vitejs/plugin-react'
+import { defineConfig } from 'vite'
+
+export default defineConfig({
+  plugins: [react()],
+})