Skip to content

Commit d1e1a0f

Browse files
committed
fix: tweak entries
1 parent 3d8256f commit d1e1a0f

File tree

8 files changed

+14
-39
lines changed

8 files changed

+14
-39
lines changed

packages/plugin-rsc/examples/react-router/cf/entry.rsc.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,3 @@ export default {
77
return fetchServer(request)
88
},
99
}
10-
11-
if (import.meta.hot) {
12-
import.meta.hot.accept()
13-
}
Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
1-
import handler from '../react-router-vite/entry.ssr'
1+
import { generateHTML } from '../react-router-vite/entry.ssr'
22

33
console.log('[debug:cf-ssr-entry]')
44

5-
// TODO:
6-
// shouldn't "entry.rsc.tsx" be the main server entry
7-
// and optionally call "entry.ssr.tsx" only for rendering html?
8-
95
export default {
106
fetch(request: Request, env: any) {
11-
return handler(request, (request) => env.RSC.fetch(request))
7+
return generateHTML(request, (request) => env.RSC.fetch(request))
128
},
139
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import { fetchServer } from './entry.rsc'
2+
3+
export default async function handler(request: Request) {
4+
// Import the generateHTML function from the client environment
5+
const ssr = await import.meta.viteRsc.loadModule<
6+
typeof import('./entry.ssr')
7+
>('ssr', 'index')
8+
9+
return ssr.generateHTML(request, fetchServer)
10+
}

packages/plugin-rsc/examples/react-router/react-router-vite/entry.rsc.tsx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,6 @@ export function fetchServer(request: Request) {
3232
})
3333
}
3434

35-
export default async function handler(request: Request) {
36-
// Import the generateHTML function from the client environment
37-
const ssr = await import.meta.viteRsc.loadModule<
38-
typeof import('./entry.ssr')
39-
>('ssr', 'index')
40-
41-
return ssr.generateHTML(request, fetchServer)
42-
}
43-
4435
if (import.meta.hot) {
4536
import.meta.hot.accept()
4637
}

packages/plugin-rsc/examples/react-router/react-router-vite/entry.ssr.single.tsx

Lines changed: 0 additions & 8 deletions
This file was deleted.

packages/plugin-rsc/examples/react-router/react-router-vite/entry.ssr.tsx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,3 @@ export async function generateHTML(
3636
},
3737
})
3838
}
39-
40-
export default async function handler(
41-
request: Request,
42-
fetchServer: (request: Request) => Promise<Response>,
43-
): Promise<Response> {
44-
return generateHTML(request, fetchServer)
45-
}

packages/plugin-rsc/examples/react-router/vite.config.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,9 @@ export default defineConfig({
1717
rsc({
1818
entries: {
1919
client: './react-router-vite/entry.browser.tsx',
20-
ssr: './react-router-vite/entry.ssr.single.tsx',
20+
ssr: './react-router-vite/entry.ssr.tsx',
2121
rsc: './react-router-vite/entry.rsc.tsx',
2222
},
23-
serverHandler: {
24-
environmentName: 'ssr',
25-
entryName: 'index',
26-
},
2723
}),
2824
inspect(),
2925
],

packages/plugin-rsc/src/plugin.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -875,6 +875,7 @@ function getEntrySource(
875875
!Array.isArray(input) &&
876876
name in input &&
877877
typeof input[name] === 'string',
878+
`[vite-rsc] expected 'build.rollupOptions.input' to be an object with a '${name}' property that is a string, but got ${JSON.stringify(input)}`,
878879
)
879880
return input[name]
880881
}

0 commit comments

Comments
 (0)