refactor(rsc): organize internal plugins (#791)

Author: hi-ogawa

packages/plugin-rsc/src/plugin.ts

@@ -48,7 +48,7 @@ import {
   withRollupError,
 } from './plugins/utils'
 import { createDebug } from '@hiogawa/utils'
-import { transformScanBuildStrip } from './plugins/scan'
+import { scanBuildStripPlugin } from './plugins/scan'
 import { validateImportPlugin } from './plugins/validate-import'
 import { vitePluginFindSourceMapURL } from './plugins/find-source-map-url'
 import { parseCssVirtual, toCssVirtual, parseIdQuery } from './plugins/shared'
@@ -90,6 +90,8 @@ function resolvePackage(name: string) {
   return pathToFileURL(require.resolve(name)).href
 }
 
+export type { RscPluginManager }
+
 class RscPluginManager {
   server!: ViteDevServer
   config!: ResolvedConfig
@@ -979,9 +981,23 @@ import.meta.hot.on("rsc:update", () => {
         return code
       },
     ),
+    ...vitePluginRscMinimal(rscPluginOptions, manager),
+    ...vitePluginFindSourceMapURL(),
+    ...vitePluginRscCss(rscPluginOptions, manager),
+    ...(rscPluginOptions.validateImports !== false
+      ? [validateImportPlugin()]
+      : []),
+    scanBuildStripPlugin({ manager }),
+    ...cjsModuleRunnerPlugin(),
+    ...globalAsyncLocalStoragePlugin(),
+  ]
+}
+
+// make `AsyncLocalStorage` available globally for React edge build (required for React.cache, ssr preload, etc.)
+// https://github.com/facebook/react/blob/f14d7f0d2597ea25da12bcf97772e8803f2a394c/packages/react-server/src/forks/ReactFlightServerConfig.dom-edge.js#L16-L19
+function globalAsyncLocalStoragePlugin(): Plugin[] {
+  return [
     {
-      // make `AsyncLocalStorage` available globally for React edge build (required for React.cache, ssr preload, etc.)
-      // https://github.com/facebook/react/blob/f14d7f0d2597ea25da12bcf97772e8803f2a394c/packages/react-server/src/forks/ReactFlightServerConfig.dom-edge.js#L16-L19
       name: 'rsc:inject-async-local-storage',
       transform: {
         handler(code) {
@@ -1004,36 +1020,9 @@ import.meta.hot.on("rsc:update", () => {
         },
       },
     },
-    ...vitePluginRscMinimal(rscPluginOptions, manager),
-    ...vitePluginFindSourceMapURL(),
-    ...vitePluginRscCss(rscPluginOptions, manager),
-    ...(rscPluginOptions.validateImports !== false
-      ? [validateImportPlugin()]
-      : []),
-    scanBuildStripPlugin({ manager }),
-    ...cjsModuleRunnerPlugin(),
   ]
 }
 
-// During scan build, we strip all code but imports to
-// traverse module graph faster and just discover client/server references.
-function scanBuildStripPlugin({
-  manager,
-}: {
-  manager: RscPluginManager
-}): Plugin {
-  return {
-    name: 'rsc:scan-strip',
-    apply: 'build',
-    enforce: 'post',
-    async transform(code, _id, _options) {
-      if (!manager.isScanBuild) return
-      const output = await transformScanBuildStrip(code)
-      return { code: output, map: { mappings: '' } }
-    },
-  }
-}
-
 function vitePluginUseClient(
   useClientPluginOptions: Pick<
     RscPluginOptions,

packages/plugin-rsc/src/plugins/scan.ts

@@ -1,6 +1,26 @@
 import * as esModuleLexer from 'es-module-lexer'
-import { parseAstAsync } from 'vite'
+import { parseAstAsync, type Plugin } from 'vite'
 import { walk } from 'estree-walker'
+import type { RscPluginManager } from '../plugin'
+
+// During scan build, we strip all code but imports to
+// traverse module graph faster and just discover client/server references.
+export function scanBuildStripPlugin({
+  manager,
+}: {
+  manager: RscPluginManager
+}): Plugin {
+  return {
+    name: 'rsc:scan-strip',
+    apply: 'build',
+    enforce: 'post',
+    async transform(code, _id, _options) {
+      if (!manager.isScanBuild) return
+      const output = await transformScanBuildStrip(code)
+      return { code: output, map: { mappings: '' } }
+    },
+  }
+}
 
 // https://github.com/vitejs/vite/blob/86d2e8be50be535494734f9f5f5236c61626b308/packages/vite/src/node/plugins/importMetaGlob.ts#L113
 const importGlobRE = /\bimport\.meta\.glob(?:<\w+>)?\s*\(/g