Skip to content

Commit fa60127

Browse files
authored
fix(rsc): await handler to avoid unhandled rejection (#576)
1 parent 7c564ff commit fa60127

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

packages/plugin-rsc/src/plugin.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,9 @@ export default function vitePluginRsc(
303303
`[vite-rsc] failed to resolve server handler '${source}'`,
304304
)
305305
const mod = await environment.runner.import(resolved.id)
306-
createRequestListener(mod.default)(req, res)
306+
// ensure catching rejected promise
307+
// https://github.com/mjackson/remix-the-web/blob/b5aa2ae24558f5d926af576482caf6e9b35461dc/packages/node-fetch-server/src/lib/request-listener.ts#L87
308+
await createRequestListener(mod.default)(req, res)
307309
} catch (e) {
308310
next(e)
309311
}
@@ -336,7 +338,7 @@ export default function vitePluginRsc(
336338
return () => {
337339
server.middlewares.use(async (req, res, next) => {
338340
try {
339-
handler(req, res)
341+
await handler(req, res)
340342
} catch (e) {
341343
next(e)
342344
}

0 commit comments

Comments
 (0)