Skip to content

Commit fec40f0

Browse files
hi-ogawaclaude
andcommitted
ci(rsc): remove workflow_dispatch inputs, use matrix-only React version testing
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent cb47d28 commit fec40f0

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

.github/workflows/ci-rsc.yml

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@ permissions: {}
44

55
on:
66
workflow_dispatch:
7-
inputs:
8-
# https://github.com/wakujs/waku/blob/fb3968b0fa6ecf3e4a50dca4a61f10ec75b793ad/.github/workflows/canary-ci.yml
9-
react_version:
10-
required: true
11-
type: string
12-
default: canary
137
push:
148
branches:
159
- main
@@ -75,11 +69,10 @@ jobs:
7569
sed -i '/^overrides:/a\ vite: "npm:rolldown-vite@latest"' pnpm-workspace.yaml
7670
pnpm i --no-frozen-lockfile
7771
- name: install react
78-
if: ${{ matrix.react_version || (inputs.react_version && inputs.react_version != 'stable') }}
72+
if: ${{ matrix.react_version }}
7973
run: |
80-
REACT_VERSION="${{ matrix.react_version || inputs.react_version }}"
81-
sed -i "/^overrides:/a\ react: \"$REACT_VERSION\"" pnpm-workspace.yaml
82-
sed -i "/^overrides:/a\ react-dom: \"$REACT_VERSION\"" pnpm-workspace.yaml
74+
sed -i "/^overrides:/a\ react: \"${{ matrix.react_version }}\"" pnpm-workspace.yaml
75+
sed -i "/^overrides:/a\ react-dom: \"${{ matrix.react_version }}\"" pnpm-workspace.yaml
8376
pnpm i --no-frozen-lockfile
8477
- run: pnpm -C packages/plugin-rsc exec playwright install ${{ matrix.browser }}
8578
- run: pnpm -C packages/plugin-rsc test-e2e-ci --project=${{ matrix.browser }}

0 commit comments

Comments
 (0)