Build failure in `rsc:use-client/build-references`

[hi-ogawa]

Regression from #794

When testing latest, I found many build failures in wakujs/waku#1655.

For example, react-tweet causes a following error:
https://stackblitz.com/edit/github-8f2jxtdr?file=src%2Froot.tsx

error during build:
[rsc:use-client/build-references] Could not load virtual:vite-rsc/client-references (imported by ../../dist/browser-QU10IP0-.js): Cannot read properties of undefined (reading 'replaceAll')
    at Object.load (file:///home/hiroshi/code/others/vite-plugin-react/packages/plugin-rsc/dist/plugin-CNxA7P6H.js:1322:28)

meta.serverChunk is expected to exist and name to be a proper string, but apparently not.

vite-plugin-react/packages/plugin-rsc/src/plugin.ts

Lines 1229 to 1236 in 2dd0993

	let name =
	useClientPluginOptions.clientChunks?.({
	id: meta.importId,
	normalizedId: manager.toRelativeId(meta.importId),
	serverChunk: meta.serverChunk!,
	}) ?? meta.serverChunk!
	// ensure clean virtual id to avoid interfering with other plugins
	name = cleanUrl(name.replaceAll('..', '__'))

[StephaneMoyart]

Hello,

i may have a similar issue currently on v 0.27 or 0.28 :

error during build:
[rsc:use-client/build-references] Could not load virtual:vite-rsc/client-references (imported by node_modules/@vitejs/plugin-rsc/dist/browser-QU10IP0-.js): Cannot read properties of undefined (reading 'replaceAll')       
    at Object.load (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/@vitejs/plugin-rsc/dist/plugin-iKgvucKS.js:1322:28)
    at Object.handler (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/vite/dist/node/chunks/dep-C6pp_iVS.js:34422:13)
    at file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:22395:40
    at async PluginDriver.hookFirstAndGetPlugin (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:22277:28)
    at async file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:21277:33
    at async Queue.work (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:22505:32)

if i go back to a previous version (0.21), all things equals i have a different error :

error during build:
src/framework/cookies.ts (2:9): "AsyncLocalStorage" is not exported by "__vite-browser-external", imported by "src/framework/cookies.ts".
file: C:/Users/33620/OneDrive/Bureau/fitengine/src/framework/cookies.ts:2:9

1: // import { serialize } from "cookie"
2: import { AsyncLocalStorage } from "node:async_hooks"
            ^
3: import { parse, serialize } from 'cookie'

    at getRollupError (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/parseAst.js:401:41)
    at error (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/parseAst.js:397:42)
    at Module.error (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:16915:16)
    at Module.traceVariable (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:17367:29)
    at ModuleScope.findVariable (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:15037:39)
    at Identifier.bind (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:5400:40)
    at NewExpression.bind (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:2791:23)
    at VariableDeclarator.bind (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:2791:23)
    at VariableDeclaration.bind (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:2787:28)
    at Program.bind (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:2787:28)
    at Module.bindReferences (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:16894:18)
    at Graph.sortModules (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:22690:20)
    at Graph.build (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:22588:14)
    at async file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:23278:13
    at async catchUnfinishedHookActions (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:22749:16)
    at async rollupInternal (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:23273:5)
    at async buildEnvironment (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/vite/dist/node/chunks/dep-C6pp_iVS.js:34239:12)
    at async Object.build (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/vite/dist/node/chunks/dep-C6pp_iVS.js:34609:19)
    at async Object.buildApp (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/@vitejs/plugin-rsc/dist/plugin-CzZCeIwj.js:503:4)
    at async Object.buildApp (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/vite/dist/node/chunks/dep-C6pp_iVS.js:34605:38)
    at async CAC.<anonymous> (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/vite/dist/node/cli.js:648:3)

so i am currently invertigating and for now cant find where i'm importing this on a client (i did the mistake to do a lot of stuff without testing new builds in between, was just running in dev), but just wanted to point out that, MAYBE, it is not coming directly from the plugin and something server side shouldnt be imported client side.

hope this can maybe help and im keeping in touch if i can find something helpfull.

if you need some things to be tried, i'm happy to help

[hi-ogawa]

The fix is merged and available from preview release https://github.com/vitejs/vite-plugin-react/runs/49826678162. Can you try that?

One possible cause of __vite-browser-external error is that you have some "use client" module including framework/cookies.ts. Other users have similar module organization issue #822.

[StephaneMoyart]

2 things :

a) i found out that a plugin i made was exporting something for the client and importing some segment middleware files (server), sending unwanted stuff on the client. Build problem is now fixed

b) the fix is working, giving same error as previous versions (expected errors), not the :

error during build:
[rsc:use-client/build-references] Could not load virtual:vite-rsc/client-references (imported by node_modules/@vitejs/plugin-rsc/dist/browser-QU10IP0-.js): Cannot read properties of undefined (reading 'replaceAll')       
    at Object.load (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/@vitejs/plugin-rsc/dist/plugin-iKgvucKS.js:1322:28)
    at Object.handler (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/vite/dist/node/chunks/dep-C6pp_iVS.js:34422:13)
    at file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:22395:40
    at async PluginDriver.hookFirstAndGetPlugin (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:22277:28)
    at async file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:21277:33
    at async Queue.work (file:///C:/Users/33620/OneDrive/Bureau/fitengine/node_modules/rollup/dist/es/shared/node-entry.js:22505:32)

Gave a free occasion to test it hehe 👍